git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Getting a commit sha1 from fast-import in a remote-helper
Date: Tue, 18 Nov 2014 12:11:47 +0900	[thread overview]
Message-ID: <20141118031147.GA15358@glandium.org> (raw)
In-Reply-To: <20141118025131.GH4336@google.com>

On Mon, Nov 17, 2014 at 06:51:31PM -0800, Jonathan Nieder wrote:
> Mike Hommey wrote:
> > On Mon, Nov 17, 2014 at 05:40:28PM -0800, Jonathan Nieder wrote:
> 
> >> How did you get that "Not a blob" message?
> >
> > When trying to *create* a tree with a commit in it, so instead of giving
> > the mark for a blob to a filemodify command, giving a mark for a commit.
> > That is what fails with "Not a blob".
> 
> Ah, I see what you were trying now.  It's complaining that the data
> and mode don't match up.  See <mode> under 'filemodify' in the manual.
> 
> Something like
> 
> 	M 160000 :1 mycommit
> 
> should work fine, though that's a pretty ugly workaround for the
> inability to do
> 
> 	ls :1

Actually, for my use, that ugly workaround actually improves things for
me, avoiding to use blobs in some of the stuff I want to store :) How
did I miss that? Thanks a lot for the enlightenment.

> [...]
> >> I think a good fix would be to teach parse_ls a mode with no <path>
> >> parameter.  Something like this (untested; needs cleanup and tests):
> >
> > This would make both your commands output the same thing, right? It
> > wouldn't help my case :)
> 
> It's easily possible my patch has a typo somewhere, but the expected
> output format would be
> 
> 	commit 6066a7eac4b2bcdb86971783b583e4e408b32e81
> 
> That wouldn't help?

Oh, so `ls <dataref>` would print out what <dataref> is? That would
definitely help, although with the trick above, I probably wouldn't
actually need it anymore.

Mike

  reply	other threads:[~2014-11-18  3:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-18  0:34 Getting a commit sha1 from fast-import in a remote-helper Mike Hommey
2014-11-18  1:40 ` Jonathan Nieder
2014-11-18  2:31   ` Mike Hommey
2014-11-18  2:51     ` Jonathan Nieder
2014-11-18  3:11       ` Mike Hommey [this message]
2014-11-19  2:18         ` Mike Hommey
2014-11-19  2:21           ` Jonathan Nieder
2014-11-19  2:27             ` Mike Hommey
2014-11-19  2:36               ` Jonathan Nieder
2014-11-18  2:21 ` Mike Hommey
2014-11-18  2:35   ` Mike Hommey
2014-11-18  3:27     ` Jonathan Nieder
2014-11-18  4:17       ` Mike Hommey
2014-11-18  2:53   ` Jonathan Nieder
2014-11-18  3:14     ` Mike Hommey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118031147.GA15358@glandium.org \
    --to=mh@glandium.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).