From: Mike Hommey <mh@glandium.org>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Getting a commit sha1 from fast-import in a remote-helper
Date: Tue, 18 Nov 2014 13:17:57 +0900 [thread overview]
Message-ID: <20141118041757.GA15972@glandium.org> (raw)
In-Reply-To: <20141118032740.GJ4336@google.com>
On Mon, Nov 17, 2014 at 07:27:41PM -0800, Jonathan Nieder wrote:
> Mike Hommey wrote:
>
> > And while I'm here, it's sad that one needs to emit a dummy cat-blob or
> > ls command to wait for a checkpoint to be finished
>
> That's a good point. (Though relying on checkpoints to read back
> information is an ugly trick, so if we can get other commands to
> provide the information you need then that would be better.)
>
> The old-fashioned way is to do "progress checkpoint done". Alas, that
> writes to the progress fd, which doesn't go to the remote helper's
> stdin. How about something like this?
How about something more generic, like "sync", which purpose would be to
request synchronisation with fast-import, which would respond "sync" on
the cat-blob fd?
Or "ping"<->"pong".
Although... I wonder if that would really be useful for anything else
than checkpoint...
That said, I, for one, would be fine if this is not "fixed" as long as
marks can be resolved some other way (and, in fact, it may turn out that
I don't need to resolve marks to sha1s at all)
Thanks for you help
Mike
next prev parent reply other threads:[~2014-11-18 4:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 0:34 Getting a commit sha1 from fast-import in a remote-helper Mike Hommey
2014-11-18 1:40 ` Jonathan Nieder
2014-11-18 2:31 ` Mike Hommey
2014-11-18 2:51 ` Jonathan Nieder
2014-11-18 3:11 ` Mike Hommey
2014-11-19 2:18 ` Mike Hommey
2014-11-19 2:21 ` Jonathan Nieder
2014-11-19 2:27 ` Mike Hommey
2014-11-19 2:36 ` Jonathan Nieder
2014-11-18 2:21 ` Mike Hommey
2014-11-18 2:35 ` Mike Hommey
2014-11-18 3:27 ` Jonathan Nieder
2014-11-18 4:17 ` Mike Hommey [this message]
2014-11-18 2:53 ` Jonathan Nieder
2014-11-18 3:14 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118041757.GA15972@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).