From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
gitster@pobox.com, sahlberg@google.com, git@vger.kernel.org,
mhagger@alum.mit.edu
Subject: Re: [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update
Date: Thu, 20 Nov 2014 13:18:32 -0500 [thread overview]
Message-ID: <20141120181831.GC2559@peff.net> (raw)
In-Reply-To: <20141120180315.GA15945@google.com>
On Thu, Nov 20, 2014 at 10:03:15AM -0800, Jonathan Nieder wrote:
> Jeff King wrote:
> > On Wed, Nov 19, 2014 at 01:40:23PM -0800, Stefan Beller wrote:
>
> >> - if (check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
> >> - strbuf_addf(err, "refusing to create ref with bad name %s",
> >> - refname);
> >> - return -1;
> >> - }
> >
> > You claimed in the cover letter that only BUG messages were changed. But
> > I think this third one is a real user-visible message.
> >
> > That being said, I think the sum total of the change to the message is
> > s/create/update/, and it's probably fine.
>
> Yeah, it we want to get the 'create' back, we could handle it by
> checking if old_sha1 is null_sha1 in transaction_update (that would
> take of other callers, too, like 'git update-ref <ref> <commit> ""').
> But I haven't convinced myself that's worth the complication --- in
> any event it could be a separate patch to avoid blocking this one.
Agreed on all of that.
-Peff
next prev parent reply other threads:[~2014-11-20 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 21:40 [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Stefan Beller
2014-11-19 21:40 ` [PATCH 1/2] refs.c: make ref_transaction_create a wrapper for ref_transaction_update Stefan Beller
2014-11-20 1:10 ` Jonathan Nieder
2014-11-20 1:12 ` Stefan Beller
2014-11-20 1:37 ` Jonathan Nieder
2014-11-20 16:00 ` Jeff King
2014-11-20 17:38 ` [PATCH v2 " Stefan Beller
2014-11-20 18:03 ` [PATCH " Jonathan Nieder
2014-11-20 18:18 ` Jeff King [this message]
2014-11-19 21:40 ` [PATCH 2/2] refs.c: make ref_transaction_delete " Stefan Beller
2014-11-20 1:11 ` Jonathan Nieder
2014-11-20 17:39 ` [PATCH v2 " Stefan Beller
2014-11-20 18:05 ` Junio C Hamano
2014-11-20 11:03 ` [PATCH 0/2] Breaking the ref-transactions-reflog series in smaller parts Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141120181831.GC2559@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sahlberg@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).