From: Jeff King <peff@peff.net>
To: Steven Noonan <steven@uplinklabs.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.2.0
Date: Thu, 27 Nov 2014 23:46:56 -0500 [thread overview]
Message-ID: <20141128044656.GA19456@peff.net> (raw)
In-Reply-To: <20141127213224.GA27443@dispater.uplinklabs.net>
[nit: when quoting in your replies, please trim quotes to a reasonable
length]
On Thu, Nov 27, 2014 at 01:32:24PM -0800, Steven Noonan wrote:
> I'm sad to report that I'm getting test failures with this release.
> Built from git and did 'make -C t prove NO_SVN_TESTS=1' and got this
> result:
> [...]
> I suspect that gnupg v2.1 is to blame somehow (I've had similar bad behavior
> with my own projects using GPG in automation). Running through several of the
> git tests shows that gpg is failing to sign:
I can reproduce here on Debian by installing gnupg2 v2.1 from
experimental (this gets installed as /usr/bin/gpg2, so I had to tweak
the code to use "gpg2" by default). In my case, gpg2 repeatedly contacts
the gpg-agent and pops up X dialogs asking to unlock keyrings in the
test suite. Hitting "cancel" causes the tests to fail. Clicking "OK"
with an empty passphrase lets the test pass.
The good news is that it is similarly broken on git v2.1.0. So this
isn't something we broke; it's the new version of gnupg2.
It's not clear to me whether this is a regression in gnupg, or if
there's some magic configuration setting we need to get the old
behavior. It seems like the new version is more aggressive in trying to
use the agent to get a passphrase, even though the keyrings in the test
are unencrypted, and do not need any passphrase. Which sounds like a bug
to me.
You might have some luck talking with the gnupg folks about this
possible bug. As a simple reproduction, doing:
cd git/t/lib-gpg
export GNUPGHOME=$PWD
echo foo | gpg --sign -a
works fine with gnupg1, or earlier versions of gnupg2. But with gnupg
2.1, it causes the agent to pop up a passphrase dialog.
-Peff
next prev parent reply other threads:[~2014-11-28 4:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 23:09 [ANNOUNCE] Git v2.2.0 Junio C Hamano
2014-11-27 21:32 ` Steven Noonan
2014-11-28 4:46 ` Jeff King [this message]
2014-11-28 9:48 ` Michael J Gruber
2014-11-28 16:50 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 12:55 ` Michael J Gruber
2014-12-02 13:40 ` [PATCH] t/lib-gpg: adjust permissions for gnupg 2.1 Michael J Gruber
2014-12-02 21:07 ` Jeff King
2014-12-02 23:57 ` Junio C Hamano
2014-12-03 0:05 ` Jeff King
2014-12-03 16:21 ` Junio C Hamano
2014-12-03 11:23 ` Michael J Gruber
2014-12-03 16:45 ` Junio C Hamano
2014-12-02 21:21 ` tests do not work with gpg 2.1 Jeff King
2014-12-02 21:30 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128044656.GA19456@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=steven@uplinklabs.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).