From: Jeff King <peff@peff.net>
To: Mark Levedahl <mlevedahl@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Øystein Walle" <oystwa@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] commit: inform pre-commit if --amend is used
Date: Fri, 28 Nov 2014 00:18:05 -0500 [thread overview]
Message-ID: <20141128051805.GA19258@peff.net> (raw)
In-Reply-To: <547737C8.7070609@gmail.com>
On Thu, Nov 27, 2014 at 09:40:08AM -0500, Mark Levedahl wrote:
> >Then when you add new arguments, the hook has to search through the
> >parameters looking for one that matches, rather than just checking "$1"
> >for "amend" (and "$2" for the new option, and so on). As long as the set
> >of options remains relatively small, I think that is preferable.
> >
> >We could also just pass them through the environment, which gives nice
> >named parameters.
> >
>
> See http://comments.gmane.org/gmane.comp.version-control.git/148479 for an
> earlier conversation on this exact topic. Also, see
> http://permalink.gmane.org/gmane.comp.version-control.git/148480 for a
> similar change in git-gui.
Thanks for the links; I had no recollection of that thread.
Unsurprisingly, I like the "HEAD"/"HEAD~1" suggestion. That "peff" guy
seems really clever (and handsome, too, I'll bet).
I'd still be OK with any of the suggestions given in this thread,
though.
-Peff
next prev parent reply other threads:[~2014-11-28 5:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 11:21 [PATCH] commit: inform pre-commit if --amend is used Øystein Walle
2014-11-24 23:14 ` Eric Sunshine
2014-11-25 3:44 ` Jeff King
2014-11-25 4:58 ` Junio C Hamano
2014-11-25 5:03 ` Jeff King
2014-11-27 14:40 ` Mark Levedahl
2014-11-28 5:18 ` Jeff King [this message]
2014-11-28 15:49 ` Mark Levedahl
2014-12-01 0:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141128051805.GA19258@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mlevedahl@gmail.com \
--cc=oystwa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).