From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: Disabling credential helper?
Date: Tue, 2 Dec 2014 17:29:50 -0800 [thread overview]
Message-ID: <20141203012950.GC6527@google.com> (raw)
In-Reply-To: <20141203012148.GB29427@peff.net>
Jeff King wrote:
> On Tue, Dec 02, 2014 at 04:59:53PM -0800, Jonathan Nieder wrote:
>> As long as you have no credential helpers configured, your GIT_ASKPASS
>> based approach should work fine.
>
> Yeah, it's fine (as is GIT_ASKPASS=true). You could also provide a
> credential helper that gives you an empty username and password. But in
> both cases, I think that git will then feed the empty password to the
> server again, resulting in an extra useless round-trip. You probably
> instead want to say "stop now, git, there is nothing else to be done".
>
> We could teach the credential-helper code to do that (e.g., a helper
> returns "stop=true" and we respect that). But I think you can do it
> reasonably well today by making the input process fail.
How can my scripts defend against a credential helper that I didn't
set up that e.g. pops up a GUI window to ask for a password?
Thanks,
Jonathan
next prev parent reply other threads:[~2014-12-03 1:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 0:03 Disabling credential helper? brian m. carlson
2014-12-03 0:59 ` Jonathan Nieder
2014-12-03 1:21 ` Jeff King
2014-12-03 1:29 ` Jonathan Nieder [this message]
2014-12-03 1:36 ` Jeff King
2014-12-04 1:33 ` Jeff King
2014-12-04 6:07 ` Junio C Hamano
2014-12-03 17:14 ` Junio C Hamano
2014-12-04 0:42 ` brian m. carlson
2014-12-04 3:42 ` [PATCH 0/2] disabling terminal prompts Jeff King
2014-12-04 3:46 ` [PATCH 1/2] credential: let helpers tell us to quit Jeff King
2014-12-04 3:52 ` [PATCH 2/2] prompt: respect GIT_TERMINAL_PROMPT to disable terminal prompts Jeff King
2014-12-04 18:24 ` Junio C Hamano
2014-12-04 21:01 ` Jeff King
2014-12-04 21:33 ` Junio C Hamano
2014-12-05 9:10 ` Jeff King
2014-12-05 17:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203012950.GC6527@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).