* [PATCH] git-svn: propset support v3
@ 2014-12-07 10:46 Alfred Perlstein
0 siblings, 0 replies; only message in thread
From: Alfred Perlstein @ 2014-12-07 10:46 UTC (permalink / raw)
To: git; +Cc: Eric Wong, Jonathan Nieder, Junio C Hamano, Michael G. Schwern
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1536 bytes --]
Added:
Eric Sunshine's:
- suggestion to include the comment about propset only
working on files with content changes.
Eric Wong's:
- use && to chain commands throughout tests
- use svn_cmd wrapper throughout tests
- show $! in die messages
- favor $(...) over `...` in tests
- make new_props an array simplify building the final list
- wrap long comments (help output still needs fixing)
- remove unnecessary FIXME comment
- commit message improvements.
Torsten Bögershausen:
- Fixes for test cases.
Finally, I have refactored the test cases to reduce duplicate code
such that further fixes and improvements can be done in one place.
JFYI, branches are here:
1st review changes:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream?expand=1
Squashed into:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff?expand=1
Current review in different commits:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream2?expand=1
Squashed into:
https://github.com/splbio/git/compare/master-git-svn-propset-upstream-one-diff2?expand=1
Thank you very much.
Alfred Perlstein (1):
git-svn: Support for git-svn propset
git-svn.perl | 49 ++++++++++++++++++++++-
perl/Git/SVN/Editor.pm | 42 ++++++++++++++++++++
t/t9148-git-svn-propset.sh | 97 ++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 187 insertions(+), 1 deletion(-)
create mode 100755 t/t9148-git-svn-propset.sh
--
2.1.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-12-07 10:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-07 10:46 [PATCH] git-svn: propset support v3 Alfred Perlstein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).