From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
Michael Haggerty <mhagger@alum.mit.edu>,
ronnie sahlberg <ronniesahlberg@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/8] Making reflog modifications part of the transactions API
Date: Mon, 8 Dec 2014 13:54:15 -0800 [thread overview]
Message-ID: <20141208215415.GS16345@google.com> (raw)
In-Reply-To: <CAGZ79kb1yiSENO+uANdeOKtcSCZgZA3UXSdE2F5PBA49erh2Jw@mail.gmail.com>
Hi,
Stefan Beller wrote:
> How do we view an empty reflog, i.e. an empty file at logs/refs/heads/master?
That's a good question. I'm a little concerned about what 'git reflog
expire --updateref' would do in this case.
It looks like the longstanding behavior is for 'git reflog expire' to
expire any entry that is old enough, even if that entry describes the
current value of the ref and the reflog becomes empty. The empty
reflog file is kind of like having no reflog at all, except it means
git should log updates to that ref even if core.logallrefupdates is
false.
That suggests that two separate operations delete_reflog (for 'git
reflog delete') and truncate_reflog (for 'git reflog expire') would be
needed.
Thanks for catching it.
Jonathan
next prev parent reply other threads:[~2014-12-08 21:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 2:46 [PATCH 0/8] Making reflog modifications part of the transactions API Stefan Beller
2014-12-06 2:46 ` [PATCH 1/8] refs.c: let fprintf handle the formatting Stefan Beller
2014-12-06 2:46 ` [PATCH 2/8] refs.c: rename the transaction functions Stefan Beller
2014-12-11 21:42 ` Junio C Hamano
2014-12-11 21:48 ` Stefan Beller
2014-12-06 2:46 ` [PATCH 3/8] refs.c: rename transaction.updates to transaction.ref_updates Stefan Beller
2014-12-06 2:46 ` [PATCH 4/8] refs.c: add transaction function to append to the reflog Stefan Beller
2014-12-11 21:50 ` Junio C Hamano
2014-12-06 2:46 ` [PATCH 5/8] refs.c: add transaction function to delete " Stefan Beller
2014-12-06 2:46 ` [PATCH 6/8] refs.c: use a reflog transaction when writing during expire Stefan Beller
2014-12-06 2:46 ` [PATCH 7/8] refs.c: rename log_ref_setup to create_reflog Stefan Beller
2014-12-06 2:46 ` [PATCH 8/8] refs.c: allow deleting refs with a broken sha1 Stefan Beller
2014-12-08 20:05 ` [PATCH 0/8] Making reflog modifications part of the transactions API Stefan Beller
2014-12-08 21:54 ` Jonathan Nieder [this message]
2014-12-12 16:17 ` Michael Haggerty
2014-12-12 20:51 ` Stefan Beller
2014-12-12 21:16 ` ronnie sahlberg
2014-12-14 23:17 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141208215415.GS16345@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=ronniesahlberg@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).