From: Max Kirillov <max@max630.net>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Jens Lehmann" <Jens.Lehmann@web.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v3 0/3] Multiple worktrees vs. submodules fixes
Date: Tue, 9 Dec 2014 07:04:35 +0200 [thread overview]
Message-ID: <20141209050435.GA9140@wheezy.local> (raw)
In-Reply-To: <1418100283-8995-1-git-send-email-max@max630.net>
On Tue, Dec 09, 2014 at 06:44:40AM +0200, Max Kirillov wrote:
> After discussions I came to basically same as v1.
>
> * Resubmitting the 2 patches which have not been taken to worktrees reroll -
> they fix visible issue. Mostly unchanged except small cleanup in test.
> * Added GIT_COMMON_DIR to local_repo_env. While it is obviously a right
> thing, I wasn't able to observe any change in behavior.
>
> Max Kirillov (3):
> submodule refactor: use git_path_submodule() in add_submodule_odb()
> path: implement common_dir handling in git_path_submodule()
> Add GIT_COMMON_DIR to local_repo_env
>
> cache.h | 1 +
> environment.c | 1 +
> path.c | 24 ++++++++++++++++++++----
> setup.c | 17 ++++++++++++-----
> submodule.c | 28 ++++++++++------------------
> t/t7410-submodule-checkout-to.sh | 10 ++++++++++
> 6 files changed, 54 insertions(+), 27 deletions(-)
>
> --
> 2.2.0.50.gb2b6831
>
Should be applied on top of
http://thread.gmane.org/gmane.comp.version-control.git/260387
with _all_ patches included, currently it's df56607dff
--
Max
prev parent reply other threads:[~2014-12-09 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 4:44 [PATCH v3 0/3] Multiple worktrees vs. submodules fixes Max Kirillov
2014-12-09 4:44 ` [PATCH v3 1/3] submodule refactor: use git_path_submodule() in add_submodule_odb() Max Kirillov
2014-12-09 4:44 ` [PATCH v3 2/3] path: implement common_dir handling in git_path_submodule() Max Kirillov
2014-12-09 4:44 ` [PATCH v3 3/3] Add GIT_COMMON_DIR to local_repo_env Max Kirillov
2014-12-09 5:04 ` Max Kirillov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209050435.GA9140@wheezy.local \
--to=max@max630.net \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).