From: Jeff King <peff@peff.net>
To: Daniel Hahler <genml+git-2014@thequod.de>
Cc: git@vger.kernel.org
Subject: Re: diff: use built-in patterns by default via git attributes
Date: Tue, 9 Dec 2014 15:42:47 -0500 [thread overview]
Message-ID: <20141209204247.GD12001@peff.net> (raw)
In-Reply-To: <54875916.7020107@thequod.de>
On Tue, Dec 09, 2014 at 09:18:30PM +0100, Daniel Hahler wrote:
> I'm wondering why the built-in patterns (defined in userdiff.c) are not
> being applied by default, e.g. what you would normally do in
> core.attributesfile via:
>
> *.py diff=python
>
> Wouldn't it make sense to provide certain defaults for attributes, where
> Git provides enhanced patterns?
It's been discussed:
http://thread.gmane.org/gmane.comp.version-control.git/187269
It ended up with a lot of back-and-forth over which extensions belonged
to which type, and whether the C funcname pattern was terrible or not. I
got sick of it and dropped the patch.
You are welcome to try resurrecting it. :) It might help to read the
discussion and drop any contentious names. Since that thread, the C/C++
pattern has improved greatly, so it might not meet so much resistance.
-Peff
prev parent reply other threads:[~2014-12-09 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 20:18 diff: use built-in patterns by default via git attributes Daniel Hahler
2014-12-09 20:42 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209204247.GD12001@peff.net \
--to=peff@peff.net \
--cc=genml+git-2014@thequod.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).