From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Blume <blume.mike@gmail.com>,
Git List <git@vger.kernel.org>,
Luis Henriques <henrix@camandro.org>
Subject: Re: no-xmailer tests fail under Mac OS
Date: Thu, 11 Dec 2014 17:13:39 -0500 [thread overview]
Message-ID: <20141211221339.GA9478@peff.net> (raw)
In-Reply-To: <xmqq1to5et1j.fsf@gitster.dls.corp.google.com>
On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote:
> >
> >> > Ah, right, we might be looking for 0 sometimes. The right way to do it
> >> > without destroying the &&-chaining is:
> >> >
> >> > { grep ^X-Mailer: out || true } &&
> >> > test_line_count = $expected mailer
> >>
> >> Hmm, it doesn't look like that helper is &&-chained though? So it
> >> seems like we could just do without the &&
> >
> > You're right, but that is IMHO a bug. We would not notice if send-email
> > or format-patch barfed, and we are expecting to find no X-Mailer (we
> > wouldn't, but for the wrong reason).
>
> Let me patch this up further by amending the SQUASH??? at the tip.
>
> t/t9001-send-email.sh | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
> [...]
Yeah, looks good to me.
-Peff
next prev parent reply other threads:[~2014-12-11 22:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 2:05 no-xmailer tests fail under Mac OS Michael Blume
2014-12-06 5:34 ` Jeff King
2014-12-06 6:27 ` Michael Blume
2014-12-06 6:32 ` Jeff King
[not found] ` <CAO2U3QgDMpKwqsjzPNECpJw4z+WbboX5ug7Shu5v5ZCuPsKuGQ@mail.gmail.com>
2014-12-06 7:12 ` Jeff King
2014-12-11 22:11 ` Junio C Hamano
2014-12-11 22:13 ` Jeff King [this message]
2014-12-11 22:35 ` Luis Henriques
2014-12-09 19:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211221339.GA9478@peff.net \
--to=peff@peff.net \
--cc=blume.mike@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=henrix@camandro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).