* [PATCH] refs: release strbuf after use in check_refname_component()
@ 2014-12-24 0:18 René Scharfe
2014-12-29 17:37 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: René Scharfe @ 2014-12-24 0:18 UTC (permalink / raw)
To: Git Mailing List; +Cc: Junio C Hamano, Ronnie Sahlberg
Signed-off-by: Rene Scharfe <l.s.r@web.de>
---
refs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs.c b/refs.c
index 5fcacc6..ed3b2cb 100644
--- a/refs.c
+++ b/refs.c
@@ -2334,7 +2334,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
struct strbuf err = STRBUF_INIT;
unable_to_lock_message(ref_file, errno, &err);
error("%s", err.buf);
- strbuf_reset(&err);
+ strbuf_release(&err);
goto error_return;
}
}
--
2.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] refs: release strbuf after use in check_refname_component()
2014-12-24 0:18 [PATCH] refs: release strbuf after use in check_refname_component() René Scharfe
@ 2014-12-29 17:37 ` Junio C Hamano
2014-12-29 21:13 ` Jeff King
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2014-12-29 17:37 UTC (permalink / raw)
To: René Scharfe; +Cc: Git Mailing List, Ronnie Sahlberg
René Scharfe <l.s.r@web.de> writes:
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
> refs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/refs.c b/refs.c
> index 5fcacc6..ed3b2cb 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -2334,7 +2334,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
> struct strbuf err = STRBUF_INIT;
> unable_to_lock_message(ref_file, errno, &err);
> error("%s", err.buf);
> - strbuf_reset(&err);
> + strbuf_release(&err);
> goto error_return;
> }
> }
The subject does not seem to match what the patch is doing, but the
patch is obviously correct ;-)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] refs: release strbuf after use in check_refname_component()
2014-12-29 17:37 ` Junio C Hamano
@ 2014-12-29 21:13 ` Jeff King
0 siblings, 0 replies; 3+ messages in thread
From: Jeff King @ 2014-12-29 21:13 UTC (permalink / raw)
To: Junio C Hamano; +Cc: René Scharfe, Git Mailing List, Ronnie Sahlberg
On Mon, Dec 29, 2014 at 09:37:43AM -0800, Junio C Hamano wrote:
> René Scharfe <l.s.r@web.de> writes:
>
> > Signed-off-by: Rene Scharfe <l.s.r@web.de>
> > ---
> > refs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/refs.c b/refs.c
> > index 5fcacc6..ed3b2cb 100644
> > --- a/refs.c
> > +++ b/refs.c
> > @@ -2334,7 +2334,7 @@ static struct ref_lock *lock_ref_sha1_basic(const char *refname,
> > struct strbuf err = STRBUF_INIT;
> > unable_to_lock_message(ref_file, errno, &err);
> > error("%s", err.buf);
> > - strbuf_reset(&err);
> > + strbuf_release(&err);
> > goto error_return;
> > }
> > }
>
> The subject does not seem to match what the patch is doing, but the
> patch is obviously correct ;-)
The worst part of this is that I got it right in my hacked-up version:
http://article.gmane.org/gmane.comp.version-control.git/259853
but then after much discussion, we dropped all of the lead-in patches,
and I sent Ronnie's unedited:
http://article.gmane.org/gmane.comp.version-control.git/259911
All that looking and I didn't notice the release/reset difference
between our two versions. Sheesh.
Which is all a roundabout way of saying "yes, René's patch is obviously
correct". :)
-Peff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-29 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-24 0:18 [PATCH] refs: release strbuf after use in check_refname_component() René Scharfe
2014-12-29 17:37 ` Junio C Hamano
2014-12-29 21:13 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).