From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Kyle J. McKay" <mackyle@gmail.com>,
Git mailing list <git@vger.kernel.org>,
Scott Chacon <schacon@gmail.com>,
Johan Herland <johan@herland.net>
Subject: Re: [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs
Date: Tue, 6 Jan 2015 20:19:58 -0500 [thread overview]
Message-ID: <20150107011958.GA3536@peff.net> (raw)
In-Reply-To: <xmqq8uhgqkge.fsf@gitster.dls.corp.google.com>
On Tue, Jan 06, 2015 at 02:20:33AM -0800, Junio C Hamano wrote:
> The fact that "git notes merge refs/heads/master" fails is a very
> good prevention of end-user mistakes, and this removal of test
> demonstrates that we are dropping a valuable safety.
Is it really that valuable? If it were:
git notes merge master
I could see somebody running that accidentally. But we are talking about
somebody who is already fully-qualifying a ref (and anything unqualified
continues to get looked up under refs/notes). Do people really go to the
length of qualifying the ref and then get confused or upset that git did
exactly what they asked it to do?
I'm worried that the end-user safety here is really a strawman, and we
are making this more complicated than it needs to be.
-Peff
next prev parent reply other threads:[~2015-01-07 1:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 8:03 [PATCH v2 0/2] Accept any notes ref Kyle J. McKay
2015-01-06 8:03 ` [PATCH v2 1/2] notes: accept any ref Kyle J. McKay
2015-01-06 8:03 ` [PATCH v2 2/2] t/t3308-notes-merge.sh: succeed with relaxed notes refs Kyle J. McKay
2015-01-06 10:20 ` Junio C Hamano
2015-01-06 12:27 ` Kyle J. McKay
2015-01-06 18:25 ` Junio C Hamano
2015-01-06 23:29 ` Kyle J. McKay
2015-01-06 23:54 ` Junio C Hamano
2015-01-07 1:27 ` Kyle J. McKay
2015-01-07 0:28 ` Johan Herland
2015-01-07 1:51 ` Kyle J. McKay
2015-01-07 16:14 ` Junio C Hamano
2015-01-07 1:19 ` Johan Herland
2015-01-07 1:19 ` Jeff King [this message]
2015-01-07 16:03 ` Junio C Hamano
2015-01-08 10:31 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107011958.GA3536@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=mackyle@gmail.com \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).