From: Jeff Sipek <jeffpc@josefsipek.net>
To: Per Cederqvist <cederp@opera.com>
Cc: git@vger.kernel.org
Subject: Re: [GUILT 4/5] doc: don't use guilt-foo invocations in usage messages.
Date: Fri, 23 Jan 2015 09:27:31 -0500 [thread overview]
Message-ID: <20150123142731.GD101465@meili.jeffnet.31bits.net> (raw)
In-Reply-To: <1422019499-2012-5-git-send-email-cederp@opera.com>
Ah, I see you changed usage.sh here. I guess that kinda invalidates my
comment for patch 1/5.
On Fri, Jan 23, 2015 at 02:24:58PM +0100, Per Cederqvist wrote:
> Signed-off-by: Per Cederqvist <cederp@opera.com>
> ---
> Documentation/usage.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/usage.sh b/Documentation/usage.sh
> index 629f546..9cc49f7
> --- a/Documentation/usage.sh
> +++ b/Documentation/usage.sh
> @@ -2,4 +2,4 @@
>
> name=$(basename $1)
> u=$(grep USAGE $1 | sed 's/USAGE="//' | sed 's/"$//')
> -echo "'$name' $u" > usage-$name.txt
> +echo "'`echo $name|sed -e 's/^guilt-/guilt /'`' $u" > usage-$name.txt
Tiny nitpick: spaces around the |, otherwise looks good.
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
> --
> 2.1.0
>
--
Si hoc legere scis nimium eruditionis habes.
next prev parent reply other threads:[~2015-01-23 14:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 13:24 [GUILT 0/5] doc: less guilt-foo invocations, minor Makefile fixes Per Cederqvist
2015-01-23 13:24 ` [GUILT 1/5] Fix generation of Documentation/usage-%.txt Per Cederqvist
2015-01-23 14:21 ` Jeff Sipek
2015-01-23 14:33 ` Per Cederqvist
2015-01-23 14:36 ` Jeff Sipek
2015-01-23 13:24 ` [GUILT 2/5] doc: guilt.xml depends on cmds.txt Per Cederqvist
2015-01-23 14:23 ` Jeff Sipek
2015-01-23 13:24 ` [GUILT 3/5] doc: don't use guilt-foo invocations in examples Per Cederqvist
2015-01-23 14:25 ` Jeff Sipek
2015-01-23 13:24 ` [GUILT 4/5] doc: don't use guilt-foo invocations in usage messages Per Cederqvist
2015-01-23 14:27 ` Jeff Sipek [this message]
2015-01-23 13:24 ` [GUILT 5/5] doc: git doesn't use git-foo invocations Per Cederqvist
2015-01-23 14:29 ` Jeff Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123142731.GD101465@meili.jeffnet.31bits.net \
--to=jeffpc@josefsipek.net \
--cc=cederp@opera.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).