From: Jeff Sipek <jeffpc@josefsipek.net>
To: Per Cederqvist <cederp@opera.com>
Cc: git@vger.kernel.org
Subject: Re: [GUILT 1/2] guilt graph: Simplify getfiles.
Date: Fri, 23 Jan 2015 09:36:37 -0500 [thread overview]
Message-ID: <20150123143637.GH101465@meili.jeffnet.31bits.net> (raw)
In-Reply-To: <1422022867-7908-2-git-send-email-cederp@opera.com>
Neat.
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
On Fri, Jan 23, 2015 at 03:21:06PM +0100, Per Cederqvist wrote:
> git diff-tree by default emits TAB-separated fields. cut by defaults
> processes TAB-separated fields. Simplify getfiles() by using TAB as
> the separator.
>
> Signed-off-by: Per Cederqvist <cederp@opera.com>
> ---
> guilt-graph | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/guilt-graph b/guilt-graph
> index 0857e0d..d90c2f1 100755
> --- a/guilt-graph
> +++ b/guilt-graph
> @@ -36,7 +36,7 @@ fi
>
> getfiles()
> {
> - git diff-tree -r "$1^" "$1" | tr '\t' ' ' | cut -d' ' -f6
> + git diff-tree -r "$1^" "$1" | cut -f2
> }
>
> cache="$GUILT_DIR/$branch/.graphcache.$$"
> --
> 2.1.0
>
--
C is quirky, flawed, and an enormous success.
- Dennis M. Ritchie.
next prev parent reply other threads:[~2015-01-23 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 14:21 [GUILT 0/2] Teach "guilt graph" to ignore some files Per Cederqvist
2015-01-23 14:21 ` [GUILT 1/2] guilt graph: Simplify getfiles Per Cederqvist
2015-01-23 14:36 ` Jeff Sipek [this message]
2015-01-23 14:21 ` [GUILT 2/2] Teach "guilt graph" the "-x exclude-pattern" option Per Cederqvist
2015-01-23 14:49 ` Jeff Sipek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123143637.GH101465@meili.jeffnet.31bits.net \
--to=jeffpc@josefsipek.net \
--cc=cederp@opera.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).