From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathon Mah <me@jonathonmah.com>, git@vger.kernel.org
Subject: Re: [PATCHv5] sha1_file: fix iterating loose alternate objects
Date: Mon, 2 Feb 2015 16:02:08 -0500 [thread overview]
Message-ID: <20150202210208.GA31675@peff.net> (raw)
In-Reply-To: <xmqq7fw0t4x8.fsf@gitster.dls.corp.google.com>
On Mon, Feb 02, 2015 at 12:49:23PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > So I actually do not see how the situation would come up in practice,
> > and possibly we could drop the iteration of the alternates' loose
> > objects entirely from this code. But certainly that is orthogonal to
> > Jonathon's fix (which is a true regression for the less-exotic case that
> > his test demonstrates).
>
> Sure.
>
> This needs to go to both 'maint' and 'master', right?
Yes (on the jk/prune-mtime topic).
-Peff
prev parent reply other threads:[~2015-02-02 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-02 20:05 [PATCHv5] sha1_file: fix iterating loose alternate objects Jonathon Mah
2015-02-02 20:27 ` Jeff King
2015-02-02 20:49 ` Junio C Hamano
2015-02-02 21:02 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202210208.GA31675@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@jonathonmah.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).