From: Olaf Hering <olaf@aepfle.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] git-gui: sort entries in tclIndex
Date: Tue, 10 Feb 2015 16:18:03 +0100 [thread overview]
Message-ID: <20150210151803.GB8965@aepfle.de> (raw)
In-Reply-To: <1422292043-12711-1-git-send-email-olaf@aepfle.de>
Ping?
On Mon, Jan 26, Olaf Hering wrote:
> ALL_LIBFILES uses wildcard, which provides the result in directory
> order. This order depends on the underlying filesystem on the
> buildhost. To get reproducible builds it is required to sort such list
> before using them.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
> git-gui/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-gui/Makefile b/git-gui/Makefile
> index cde8b2e..7564a18 100644
> --- a/git-gui/Makefile
> +++ b/git-gui/Makefile
> @@ -258,7 +258,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> rm -f $@ ; \
> echo '# Autogenerated by git-gui Makefile' >$@ && \
> echo >>$@ && \
> - $(foreach p,$(PRELOAD_FILES) $(ALL_LIBFILES),echo '$(subst lib/,,$p)' >>$@ &&) \
> + $(foreach p,$(PRELOAD_FILES) $(sort $(ALL_LIBFILES)),echo '$(subst lib/,,$p)' >>$@ &&) \
> echo >>$@ ; \
> fi
>
next prev parent reply other threads:[~2015-02-10 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 17:07 [PATCH] git-gui: sort entries in tclIndex Olaf Hering
2015-02-10 15:18 ` Olaf Hering [this message]
2015-04-15 7:22 ` Olaf Hering
2015-04-25 16:27 ` René Scharfe
2015-05-01 14:57 ` Pat Thoyts
2015-10-05 7:43 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150210151803.GB8965@aepfle.de \
--to=olaf@aepfle.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).