From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] transport-helper: ask the helper to set the same options for import as for fetch
Date: Sat, 14 Feb 2015 07:14:50 +0900 [thread overview]
Message-ID: <20150213221450.GA24285@glandium.org> (raw)
In-Reply-To: <xmqqwq3lmwnb.fsf@gitster.dls.corp.google.com>
On Fri, Feb 13, 2015 at 11:36:24AM -0800, Junio C Hamano wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > A remote helper is currently only told about the 'check-connectivity',
> > 'cloning', and 'update-shallow' options when it supports the 'fetch'
> > command, but not when it supports 'import' instead.
>
> Sounds sensible.
>
> Does the same issue exist for export vs push or do they happen to be
> coded to pass similar enough set of options already by copied and
> pasted code?
The issue exists:
- export is given dry-run, pushcert and force.
- push is given cas, dry-run and pushcert.
(note: cas and pushcert are both not documented in
gitremote-helpers.txt)
Force is actually not necessary for push, because the push syntax itself
includes the force instruction in the refspec given as argument.
I haven't looked exactly what cas does and if it makes sense for export.
(FWIW, I'm using push and import at the moment, so it's not a direct
issue for me ; I don't support cas anyways)
Mike
next prev parent reply other threads:[~2015-02-13 22:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 10:09 [PATCH 1/3] transport-helper: emit progress and verbosity options after asking for capabilities Mike Hommey
2015-02-12 10:10 ` [PATCH 2/3] transport-helper: emit check-connectivity, cloning, and update-shallow options for import Mike Hommey
2015-02-12 10:10 ` [PATCH 3/3] transport-helper: fix typo in error message when --signed is not supported Mike Hommey
2015-02-12 10:20 ` Mike Hommey
2015-02-12 20:34 ` Junio C Hamano
2015-02-12 20:28 ` [PATCH 1/3] transport-helper: emit progress and verbosity options after asking for capabilities Junio C Hamano
2015-02-13 5:24 ` [PATCH 1/2] transport-helper: ask the helper to set progress and verbosity options after asking for its capabilities Mike Hommey
2015-02-13 5:24 ` [PATCH 2/2] transport-helper: ask the helper to set the same options for import as for fetch Mike Hommey
2015-02-13 19:36 ` Junio C Hamano
2015-02-13 22:14 ` Mike Hommey [this message]
2015-02-14 8:12 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150213221450.GA24285@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).