From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH 3/2] push: allow --follow-tags to be set by config push.followTags Date: Mon, 16 Feb 2015 01:17:36 -0500 Message-ID: <20150216061736.GD32381@peff.net> References: <1424055690-32631-1-git-send-email-cxreg@pobox.com> <20150216052049.GA5031@peff.net> <20150216054550.GA24611@peff.net> <20150216055422.GB24611@peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Dave Olszewski , Git Mailing List To: Junio C Hamano X-From: git-owner@vger.kernel.org Mon Feb 16 07:17:44 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YNF02-000142-TV for gcvg-git-2@plane.gmane.org; Mon, 16 Feb 2015 07:17:43 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754302AbbBPGRj (ORCPT ); Mon, 16 Feb 2015 01:17:39 -0500 Received: from cloud.peff.net ([50.56.180.127]:49415 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751095AbbBPGRi (ORCPT ); Mon, 16 Feb 2015 01:17:38 -0500 Received: (qmail 9419 invoked by uid 102); 16 Feb 2015 06:17:38 -0000 Received: from Unknown (HELO peff.net) (10.0.1.1) by cloud.peff.net (qpsmtpd/0.84) with SMTP; Mon, 16 Feb 2015 00:17:38 -0600 Received: (qmail 12584 invoked by uid 107); 16 Feb 2015 06:17:43 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.84) with SMTP; Mon, 16 Feb 2015 01:17:43 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 16 Feb 2015 01:17:36 -0500 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Feb 15, 2015 at 10:11:21PM -0800, Junio C Hamano wrote: > On Sun, Feb 15, 2015 at 10:02 PM, Junio C Hamano wrote: > > On Sun, Feb 15, 2015 at 9:54 PM, Jeff King wrote: > >> > >> Or alternatively, we could pull the "flags" field from cmd_push out into > >> a static global "transport_flags", and manipulate it directly from the > >> config (or if we don't like a global, pass it via the config-callback > >> void pointer; but certainly a global is more common in git for code like > >> this). Then we do not have to worry about propagating values from > >> integers into flag bits at all. > > > > Yup, that would be my preference. The largest problem I had with the > > original change was how to ensure that future new code would not > > mistakenly set the global follow_tags _without_ letting the command > > line option parser to override it. If the config parser flips the bit in the > > same flags, it would become much less likely for future code to make > > such a mistake. > > Having said that, I think this version is good enough. Too late. :) I am OK if we leave it here, though, and drop the extra two patches I just sent. -Peff