From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Eric Blake <eblake@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
qemu-devel@nongnu.org, tangchen@cn.fujitsu.com,
chen.fan.fnst@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com,
imammedo@redhat.com, guz.fnst@cn.fujitsu.com,
anshul.makkar@profitbricks.com, afaerber@suse.de,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] send-email: ask confirmation if given encoding name is very short
Date: Wed, 18 Feb 2015 13:58:12 -0500 [thread overview]
Message-ID: <20150218185812.GC7257@peff.net> (raw)
In-Reply-To: <xmqqiof14hax.fsf_-_@gitster.dls.corp.google.com>
On Mon, Feb 16, 2015 at 02:34:14PM -0800, Junio C Hamano wrote:
> Sometimes people respond "y<ENTER>" (or "yes<ENTER>") when asked
> this question:
>
> Which 8bit encoding should I declare [UTF-8]?
>
> We already have a mechanism to avoid accepting a mistyped e-mail
> address (we ask to confirm when the given address lacks "@" in it);
> reuse it to trigger the same confirmation when given a very short
> answer. As a typical charset name is probably at least 4 chars or
> longer (e.g. "UTF8" spelled without the dash, or "Big5"), this would
> prevent such a mistake.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>
> * Will mark to be merged to 'next'.
Probably belated review, but this looks good to me.
-Peff
prev parent reply other threads:[~2015-02-18 18:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1421214154.git.zhugh.fnst@cn.fujitsu.com>
[not found] ` <20150205114914.GA10126@stefanha-thinkpad.redhat.com>
2015-02-05 15:25 ` [Qemu-devel] [PATCH v3 0/7] cpu: add device_add foo-x86_64-cpu support Eric Blake
2015-02-05 19:29 ` Junio C Hamano
2015-02-05 19:57 ` Jeff King
2015-02-05 20:17 ` Junio C Hamano
2015-02-06 19:33 ` Jeff King
2015-02-04 9:07 ` Invalid responses to 8bit encoding and In-Reply-To questions Geert Uytterhoeven
2015-02-04 18:34 ` Junio C Hamano
2015-04-01 10:53 ` Guilhem Bichot
2015-04-01 18:03 ` Junio C Hamano
2015-02-16 22:34 ` [PATCH] send-email: ask confirmation if given encoding name is very short Junio C Hamano
2015-02-18 18:58 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150218185812.GC7257@peff.net \
--to=peff@peff.net \
--cc=afaerber@suse.de \
--cc=anshul.makkar@profitbricks.com \
--cc=chen.fan.fnst@cn.fujitsu.com \
--cc=eblake@redhat.com \
--cc=geert@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guz.fnst@cn.fujitsu.com \
--cc=imammedo@redhat.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=tangchen@cn.fujitsu.com \
--cc=zhugh.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).