From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ryuichi Kokubo <ryu1kkb@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] git-svn: fix localtime=true on non-glibc environments
Date: Wed, 25 Feb 2015 19:42:13 +0000 [thread overview]
Message-ID: <20150225194213.GA32026@dcvr.yhbt.net> (raw)
In-Reply-To: <xmqqfv9tomzx.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
> Ryuichi Kokubo <ryu1kkb@gmail.com> writes:
>
> > git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time.
> > But lowercase %s formatting character is a GNU extention. This causes problem
> > in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.
> > Using Time::Local::timelocal($sec, $min, ...) fixes it.
> >
> > Signed-off-by: Ryuichi Kokubo <ryu1kkb@gmail.com>
>
> Sounds sensible.
>
> Because we already have "use Time::Local qw(...)" in perl/Git.pm
> that is used by git-svn, we know the platforms that are capable
> of running the current git-svn do have Time::Local available, so
> I do not have worries about new dependency, either.
>
> Eric?
Looks good, thanks. Signed-off and queued up.
prev parent reply other threads:[~2015-02-25 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 16:04 [PATCH] git-svn: fix localtime=true on non-glibc environments Ryuichi Kokubo
2015-02-25 18:38 ` Junio C Hamano
2015-02-25 19:42 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150225194213.GA32026@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ryu1kkb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox