From: Michal Hocko <mhocko@suse.cz>
To: git@vger.kernel.org
Subject: Re: git describe --contains doesn't work properly for a commit
Date: Thu, 26 Feb 2015 15:23:14 +0100 [thread overview]
Message-ID: <20150226142314.GC14878@dhcp22.suse.cz> (raw)
In-Reply-To: <20150226133534.GB14878@dhcp22.suse.cz>
On Thu 26-02-15 14:35:34, Michal Hocko wrote:
> Hi,
> I have just encountered an old kernel git commit:
> commit c854363e80b49dd04a4de18ebc379eb8c8806674
> Author: Dave Chinner <david@fromorbit.com>
> Date: Sat Feb 6 12:39:36 2010 +1100
>
> xfs: Use delayed write for inodes rather than async V2
> [...]
OK, I've managed to recreate this in a simple repo with 3 commits:
$ git log --format="%H %cd"
ab0efec2b697f2f9f864bb0e2cd77308d1f04561 Thu Feb 26 15:18:36 2015 +0100
d63972e4e4e7eda0444e56739ad09bfbc476b9bd Wed Feb 26 15:18:30 2014 +0100
108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3 Thu Feb 26 14:57:29 2015 +0100
The commit in the middle was ammended to have committer date in the
past.
$ git describe --contains d63972e4e4e7eda0444e56739ad09bfbc476b9bd
tag~1
but
$ git describe --contains 108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3
fatal: cannot describe '108a0d5972fd2e5f25b2f38cfd2fee73031ff9d3'
I guess this is the same issue reported previously here:
http://git.661346.n2.nabble.com/git-describe-contains-fails-on-given-tree-td5448286.html
Can this be fixed somehow or it would lead to other kind of issues?
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2015-02-26 14:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-26 13:35 git describe --contains doesn't work properly for a commit Michal Hocko
2015-02-26 14:23 ` Michal Hocko [this message]
2015-03-04 10:54 ` Jeff King
2015-03-04 15:06 ` Michael J Gruber
2015-03-04 18:05 ` Jeff King
2015-03-04 20:41 ` Junio C Hamano
2015-03-04 22:05 ` Mike Hommey
2015-03-05 5:12 ` Jeff King
2015-03-05 6:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226142314.GC14878@dhcp22.suse.cz \
--to=mhocko@suse.cz \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox