From: Torstein Hegge <hegge@resisty.net>
To: Caleb Thompson <caleb@calebthompson.io>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Jeremiah Mahler <jmmahler@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v6 0/4] commit: Add commit.verbose configuration
Date: Fri, 27 Feb 2015 10:13:36 +0100 [thread overview]
Message-ID: <20150227091333.GA32617@pvv.ntnu.no> (raw)
In-Reply-To: <cover.1403033723.git.caleb@calebthompson.io>
On Tue, Jun 17, 2014 at 14:38:56 -0500, Caleb Thompson wrote:
> This patch allows people to set commit.verbose to implicitly send
> --verbose to git-commit.
>
> It introduces several cleanup patches to t/t7505-commit-verbose.sh to
> bring it closer to the current state of the tests as they have been
> explained to me, then adds the verbose config and --no-verbose flag.
>
> Since the last version of this patch
> (http://thread.gmane.org/gmane.comp.version-control.git/251486), there
> have been a couple of commit message clarifications and the body of the
> check-for-no-diff script in the last patch was changed to simply negate
> check-for-diff.
Hi Caleb,
Do you intend to work further on this topic? I have been using a similar
(but less polished) patch, and would like to see this included in Git.
If you don't have time to work on it, I can incorporate the comments on
this version and submit a v7.
Torstein
next prev parent reply other threads:[~2015-02-27 9:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-17 19:38 [PATCH v6 0/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 1/4] commit test: Use test_config instead of git-config Caleb Thompson
2014-06-17 21:31 ` Junio C Hamano
2014-06-17 21:35 ` Junio C Hamano
2014-06-17 19:38 ` [PATCH v6 2/4] commit test: Use write_script Caleb Thompson
2014-06-17 19:38 ` [PATCH v6 3/4] commit test: test_set_editor in each test Caleb Thompson
2014-06-17 19:39 ` [PATCH v6 4/4] commit: Add commit.verbose configuration Caleb Thompson
2014-06-17 21:21 ` Jeff King
2014-06-17 21:37 ` Junio C Hamano
2014-06-17 21:39 ` Jeff King
2015-02-27 9:13 ` Torstein Hegge [this message]
2015-03-02 19:02 ` [PATCH v6 0/4] " Caleb Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227091333.GA32617@pvv.ntnu.no \
--to=hegge@resisty.net \
--cc=caleb@calebthompson.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jmmahler@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).