From: Jeff King <peff@peff.net>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Heald, Mike" <mike.heald@hp.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Deadlock during remote update
Date: Fri, 27 Feb 2015 08:21:13 -0500 [thread overview]
Message-ID: <20150227132113.GB13005@peff.net> (raw)
In-Reply-To: <CACsJy8AG9ZdhZj_pAb3sZPntBt+GPLj06dXDAV=w+5HyL6D+0Q@mail.gmail.com>
On Fri, Feb 27, 2015 at 06:27:28PM +0700, Duy Nguyen wrote:
> > 31638 git-remote-https upstream https://git.openstack.org/openstack/nova
> > has pipe:[170381707] (fd 1), waiting for read from pipe:[170384472]
> > 31642 git fetch-pack --stateless-rpc --lock-pack --include-tag --thin --no-progress https://git.openstack.org/openstack/nova/ efs/heads/master
> > has pipe:[170384472] (fd 1), waiting for read from pipe:[170384471] (fd 0) which fd 7 on 31638
> >
> > 31638 and 31642 are both waiting to read from a pipe that the other has, and isn't writing to.
> >
> > This is git version 1.7.9.5, OS is ubuntu precise.
>
> There's this commit 2a45520 (remote-curl: always parse incoming refs -
> 2013-02-20) that fixes a deadlock between remote-http(s) and
> fetch-pack. I'm not sure if it's the same problem. Jeff knows more
> about this. The fix is available since v1.8.3
You are more optimistic about my memory than I am. :)
Given the symptoms of the deadlock above, I agree it is a likely
culprit. There was a spree of deadlock fixes around the same time, but I
think that is the only one that was found on the client side of a fetch.
-Peff
prev parent reply other threads:[~2015-02-27 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 11:03 Deadlock during remote update Heald, Mike
2015-02-27 11:27 ` Duy Nguyen
2015-02-27 13:21 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150227132113.GB13005@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mike.heald@hp.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).