From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Noel Grandin <noel@peralex.com>,
Trevor Saunders <tbsaunde@tbsaunde.org>,
Duy Nguyen <pclouds@gmail.com>, git <git@vger.kernel.org>
Subject: Re: feature request: excluding files/paths from "git grep"
Date: Thu, 5 Mar 2015 00:22:06 -0500 [thread overview]
Message-ID: <20150305052206.GC3344@peff.net> (raw)
In-Reply-To: <xmqq385k8ot1.fsf@gitster.dls.corp.google.com>
On Wed, Mar 04, 2015 at 12:56:10PM -0800, Junio C Hamano wrote:
> > As in, while working on a specific project, I sometimes just want to
> > exclude, for the time being, a bunch of stuff from 'git grep'.
>
> The key word here is "for the time being", though. What would you
> do once you are done with the "for the time being" activity? "git
> config --unset"?
IMHO this is being too paternalistic. You can already shoot yourself
in the foot by configuring an alias to grep, running your alias, and
wondering why it does not produce the results you wanted.
But I'd also oppose a `grep.pathspecs` config option for a similar
reason: you can already accomplish the same thing (and more) with an
alias.
-Peff
PS One annoying thing about aliases is that you cannot re-alias an
existing command, and git has already taken all of the good, easy
names that we have trained our fingers for. :)
Of course re-aliasing git-grep is another recipe for head-scratching
(and broken scripts), but I am not sure there aren't a host of other
ways to do a similar thing (basically any configuration option has
the capacity to produce unexpected results if you forget that it is
set).
I dunno. Probably I am a bad person for dredging up that ancient
argument again.
next prev parent reply other threads:[~2015-03-05 5:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 12:23 feature request: excluding files/paths from "git grep" Noel Grandin
2015-02-25 13:46 ` Duy Nguyen
2015-02-25 14:31 ` Jeff King
2015-02-25 18:33 ` Junio C Hamano
2015-02-25 18:51 ` Jeff King
2015-02-25 19:01 ` Junio C Hamano
2015-02-25 19:11 ` Jeff King
2015-02-26 11:16 ` Michael J Gruber
2015-02-26 11:58 ` Duy Nguyen
2015-02-26 20:59 ` Junio C Hamano
2015-02-27 15:13 ` Michael J Gruber
2015-02-27 19:17 ` Junio C Hamano
2015-02-27 10:04 ` Trevor Saunders
2015-03-01 3:06 ` Junio C Hamano
2015-03-01 13:03 ` Trevor Saunders
2015-03-01 23:22 ` Junio C Hamano
2015-03-02 12:50 ` Trevor Saunders
2015-03-04 11:25 ` Noel Grandin
2015-03-04 20:56 ` Junio C Hamano
2015-03-05 5:22 ` Jeff King [this message]
2015-03-05 6:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305052206.GC3344@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=noel@peralex.com \
--cc=pclouds@gmail.com \
--cc=tbsaunde@tbsaunde.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).