From: Jeff King <peff@peff.net>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] t5528: do not fail with FreeBSD shell
Date: Mon, 9 Mar 2015 02:04:04 -0400 [thread overview]
Message-ID: <20150309060403.GA27128@peff.net> (raw)
In-Reply-To: <211E8F7E-5588-45B1-ACF6-BB7DFB798ABB@gmail.com>
On Sun, Mar 08, 2015 at 10:19:20PM -0700, Kyle J. McKay wrote:
> >I am not convinced this isn't a violation of POSIX (which specifies that
> >field splitting is done on the results of parameter expansions outside
> >of double-quotes). But whether it is or not, we have to live with it.
>
> That's not the only problem the shell has, t5560 had an issue, rebase had
> issues. They've have been worked around. It probably also affects related
> BSDs' shells as well (at least older versions that didn't change the shell).
Yeah, I hope that didn't come across as "bleh, this shell is not worth
supporting". It was "whether I think it is a bug or not, it is a real
problem and we must work around it".
> >For my own curiosity, what does:
> [...]
Thanks. Weird behavior, certainly, but I think the solution in your
patch is the right thing to do.
-Peff
prev parent reply other threads:[~2015-03-09 6:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 15:37 [PATCH] t5528: do not fail with FreeBSD shell Kyle J. McKay
2015-03-08 17:56 ` Jeff King
2015-03-09 5:19 ` Kyle J. McKay
2015-03-09 6:04 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309060403.GA27128@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).