From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Shawn Pearce <spearce@spearce.org>, git <git@vger.kernel.org>
Subject: Re: git commit --amend safety check?
Date: Wed, 11 Mar 2015 15:33:35 +0900 [thread overview]
Message-ID: <20150311063335.GA20713@glandium.org> (raw)
In-Reply-To: <CAPc5daVMec1okdBW3Wo_gEr7W3FwRwmH5pmiiMaAgGoN7MGa_A@mail.gmail.com>
On Tue, Mar 10, 2015 at 11:18:45PM -0700, Junio C Hamano wrote:
> One thing we already do is to give an extra "Author: " line in the
> comment when the user edits the log message, so that it is clear
> that what is being edited is not their own work but hers. We obviously
> can add the extra warning, when the is_ancestor() thing triggers, to
> say YOU ARE REWRITING PUBLISHED HISTORY in blinking red
> bold letters there.
>
> But the symptom indicates that they are not reading these warning
> comment.
Maybe they would if the warnings were a big paragraph *before* the
commit message (but brains are easily trained to recognize patterns and
skip them, so that would need to be done for very specific warnings,
not for everything that's printed in a git commit editor).
Mike
next prev parent reply other threads:[~2015-03-11 8:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 4:31 git commit --amend safety check? Shawn Pearce
2015-03-11 5:11 ` Junio C Hamano
2015-03-11 6:00 ` Shawn Pearce
2015-03-11 6:18 ` Junio C Hamano
2015-03-11 6:33 ` Mike Hommey [this message]
2015-03-11 8:13 ` Jeff King
2015-03-11 8:37 ` Peter Krefting
2015-03-11 17:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311063335.GA20713@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).