From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: [PATCH 0/7] fix transfer.hiderefs with smart http
Date: Fri, 13 Mar 2015 00:59:52 -0400 [thread overview]
Message-ID: <20150313045952.GA18853@peff.net> (raw)
In-Reply-To: <20150313044101.GA18476@peff.net>
On Fri, Mar 13, 2015 at 12:41:01AM -0400, Jeff King wrote:
> I'm experimenting with using transfer.hiderefs on a server, and it's
> rather easy to cause a git client to hang when fetching from such a repo
> over smart http. Details are in the first patch.
A note on this hang. What happens is that upload-pack sees a bogus
"want" line and calls die(). The client then sits there forever, but I'm
not exactly sure what it's waiting for.
This series fixes the bug that caused us to erroneously call die() in
upload-pack, so the hang is "fixed". But there are other reasons to call
die(); it would probably be a good thing if the client side noticed the
problem and aborted.
-Peff
next prev parent reply other threads:[~2015-03-13 4:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 4:41 [PATCH 0/7] fix transfer.hiderefs with smart http Jeff King
2015-03-13 4:42 ` [PATCH 1/7] upload-pack: fix transfer.hiderefs over smart-http Jeff King
2015-03-13 6:21 ` Junio C Hamano
2015-03-13 4:42 ` [PATCH 2/7] upload-pack: do not check NULL return of lookup_unknown_object Jeff King
2015-03-13 4:48 ` [PATCH 3/7] t: translate SIGINT to an exit Jeff King
2015-03-13 4:50 ` [PATCH 4/7] t: redirect stderr GIT_TRACE to descriptor 4 Jeff King
2015-03-13 4:51 ` [PATCH 5/7] t: pass GIT_TRACE through Apache Jeff King
2015-03-13 4:53 ` [PATCH 6/7] t5541: move run_with_cmdline_limit to test-lib.sh Jeff King
2015-03-13 6:45 ` Eric Sunshine
2015-03-13 4:57 ` [PATCH 7/7] t5551: make EXPENSIVE test cheaper Jeff King
2015-03-13 4:59 ` Jeff King [this message]
2015-03-13 5:21 ` [PATCH 0/7] fix transfer.hiderefs with smart http Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313045952.GA18853@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).