From: Jeff King <peff@peff.net>
To: Spencer Nelson <s@spenczar.com>
Cc: git@vger.kernel.org
Subject: [PATCH] clone: drop period from end of die_errno message
Date: Wed, 18 Mar 2015 15:02:01 -0400 [thread overview]
Message-ID: <20150318190200.GC650@peff.net> (raw)
In-Reply-To: <20150318185531.GA650@peff.net>
We do not usually end our errors with a full stop, but it
looks especially bad when you use die_errno, which adds a
colon, like:
fatal: could not create work tree dir 'foo'.: No such file or directory
Signed-off-by: Jeff King <peff@peff.net>
---
Not strictly related to the other patch, but I noticed it while playing
around.
builtin/clone.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/clone.c b/builtin/clone.c
index 9572467..aa01437 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -848,7 +848,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
die_errno(_("could not create leading directories of '%s'"),
work_tree);
if (!dest_exists && mkdir(work_tree, 0777))
- die_errno(_("could not create work tree dir '%s'."),
+ die_errno(_("could not create work tree dir '%s'"),
work_tree);
set_git_work_tree(work_tree);
}
--
2.3.3.520.g3cfbb5d
prev parent reply other threads:[~2015-03-18 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 18:03 git clone doesn't cleanup on failure when getcwd fails Spencer Nelson
2015-03-18 18:55 ` [PATCH] clone: initialize atexit cleanup handler earlier Jeff King
2015-03-18 19:02 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318190200.GC650@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=s@spenczar.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).