From: Paul Mackerras <paulus@samba.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git mailing list <git@vger.kernel.org>,
patthoyts@users.sourceforge.net,
Alex Henrie <alexhenrie24@gmail.com>
Subject: Re: [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it
Date: Sun, 22 Mar 2015 14:40:12 +1100 [thread overview]
Message-ID: <20150322034012.GD14271@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <xmqqlhk6agxg.fsf@gitster.dls.corp.google.com>
On Mon, Feb 09, 2015 at 01:55:23PM -0800, Junio C Hamano wrote:
> Alex Henrie <alexhenrie24@gmail.com> writes:
>
> > This is just a friendly reminder that this patch has been sitting in
> > the mailing list archives for a couple of weeks, and it has not yet
> > been accepted or commented on.
>
> I think that is because the message was not sent to the right
> people, and also because the patch was made against a wrong project
> ;-).
>
> I'll forward it to the gitk maintainer after digging it out of the
> archive and tweaking it. Thanks.
>
> Paul, comments?
>
> -- >8 --
> From: Alex Henrie <alexhenrie24@gmail.com>
> Date: Thu, 22 Jan 2015 01:19:39 -0700
> Subject: gitk: Remove tcl-format flag from a message that shouldn't have it
>
> xgettext sees "% o" and interprets it as a placeholder for an octal
> number preceded by a space. However, in this case it's not actually a
> placeholder, and most translations will replace the "% o" sequence with
> something else. Removing the tcl-format flag from this string prevents
> tools like Poedit from freaking out when "% o" doesn't appear in the
> translated string.
>
> The corrected flag will appear in each translation's po file the next time
> the translation is updated with `make update-po`.
>
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
Thanks, applied.
Paul.
prev parent reply other threads:[~2015-03-22 3:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 8:19 [PATCH] gitk: Remove tcl-format flag from a message that shouldn't have it Alex Henrie
2015-02-09 21:36 ` Alex Henrie
2015-02-09 21:55 ` Junio C Hamano
2015-02-16 23:27 ` Alex Henrie
2015-02-23 22:30 ` Alex Henrie
2015-03-10 18:53 ` Alex Henrie
2015-03-22 3:40 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150322034012.GD14271@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).