From: Vitor Antunes <vitor.hda@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Pete Wyckoff <pw@padd.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] git-p4: Fix copy detection test
Date: Fri, 27 Mar 2015 23:59:02 +0000 [thread overview]
Message-ID: <20150327235902.25ebf380@pt-vhugo> (raw)
In-Reply-To: <xmqq619mw04r.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> wrote:
>Vitor Antunes <vitor.hda@gmail.com> writes:
>
>> File file11 is copied from file2 and diff-tree correctly reports this file as
>> its the source, but the test expression was checking for file10 instead (which
>> was a file that also originated from file2). It is possible that the diff-tree
>> algorithm was updated in recent versions, which resulted in this mismatch in
>> behavior.
>>
>> Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
>
>Pete, these tests blame to your 9b6513ac (git p4 test: split up big
>t9800 test, 2012-06-27). I presume that you tested the result of
>this splitting, but do you happen to know if we did something to
>cause the test to break recently?
I also worked on these tests at that time and they were passing before and
after the reorganization. I'll prepare a bisect script and will try to find the
commit that started making this test fail.
next prev parent reply other threads:[~2015-03-27 23:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 1:04 [PATCH 0/2] git-p4: Small updates to test cases Vitor Antunes
2015-03-27 1:04 ` [PATCH 1/2] git-p4: Make rename test case runnable under dash Vitor Antunes
2015-03-27 1:04 ` [PATCH 2/2] git-p4: Fix copy detection test Vitor Antunes
2015-03-27 22:23 ` Junio C Hamano
2015-03-27 23:59 ` Vitor Antunes [this message]
2015-03-28 0:36 ` Vitor Antunes
2015-03-28 16:12 ` Junio C Hamano
2015-03-27 1:26 ` [PATCH 0/2] git-p4: Small updates to test cases Junio C Hamano
2015-03-27 1:45 ` Junio C Hamano
2015-03-27 1:54 ` Vitor Antunes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327235902.25ebf380@pt-vhugo \
--to=vitor.hda@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).