git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH 1/3] t/lib-httpd: load mod_unixd
Date: Fri, 10 Apr 2015 05:09:14 +0200	[thread overview]
Message-ID: <20150410030913.GA11280@peff.net> (raw)
In-Reply-To: <55264615.2050107@drmicha.warpmail.net>

On Thu, Apr 09, 2015 at 11:27:49AM +0200, Michael J Gruber wrote:

> In my case (apache 2.4, fedora 21), t/lib-http.sh failed to start the
> web server, so the tests above would (succeed trivially but) not run.
> 
> Maybe debian is using an apache default config that has mod_unixd built
> in, to ease the transition from apache 2.2? Many were bitten by these
> new requirements after the switch to 2.4, and some distros may have
> worked around that.

Yes, this is exactly it. On my Debian system:

  $ apache2 -l
  Compiled in modules:
    core.c
    mod_so.c
    mod_watchdog.c
    http_core.c
    mod_log_config.c
    mod_logio.c
    mod_version.c
    mod_unixd.c

> Do your tests run with this patch applied?

Yes. I think your patch is fine, as the IfModule means we handle both
the built-in and dynamic cases.

-Peff

  reply	other threads:[~2015-04-10  3:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 15:05 [PATCH 0/3] Make httpd tests run Michael J Gruber
2015-04-08 15:05 ` [PATCH 1/3] t/lib-httpd: load mod_unixd Michael J Gruber
     [not found]   ` <5525A208.6060807@web.de>
2015-04-09  9:27     ` Michael J Gruber
2015-04-10  3:09       ` Jeff King [this message]
2015-04-08 15:05 ` [PATCH 2/3] t/lib-git-svn: check same httpd module dirs as lib-httpd Michael J Gruber
2015-04-08 15:05 ` [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4 Michael J Gruber
2015-04-08 20:26   ` Eric Wong
2015-04-09  9:33     ` Michael J Gruber
2015-04-09 19:11       ` Eric Wong
2015-04-10  3:23   ` Jeff King
2015-04-10  3:39     ` Jeff King
2015-04-13 10:14       ` Michael J Gruber
2015-04-09 13:04 ` [PATCH 0/3] Make httpd tests run Kyle J. McKay
2015-04-09 13:14   ` Kyle J. McKay
2015-05-11 11:54     ` [PATCHv2 0/4] Make httpd tests run v2 Michael J Gruber
2015-05-11 11:54       ` [PATCHv2 1/4] t/lib-httpd: load mod_unixd Michael J Gruber
2015-05-11 11:54       ` [PATCHv2 2/4] t/lib-git-svn: check same httpd module dirs as lib-httpd Michael J Gruber
2015-05-11 11:54       ` [PATCH 3/4] t/t91*: do not say how to avoid the tests Michael J Gruber
2015-05-11 11:54       ` [PATCHv2 4/4 (was 3/3, still WIP)] t/lib-git-svn: adjust config to apache 2.4 WIP Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150410030913.GA11280@peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).