git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Phillip Susi <psusi@ubuntu.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: gitk won't show notes?
Date: Sat, 11 Apr 2015 20:31:56 +1000	[thread overview]
Message-ID: <20150411103156.GA5781@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <5525164C.6000309@drmicha.warpmail.net>

On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote:
> Phillip Susi venit, vidit, dixit 07.04.2015 19:08:
> > On 4/7/2015 10:13 AM, Michael J Gruber wrote:
> >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the 
> >> latter is the thorougher refreshment.
> > 
> > Neither one makes newly added notes show up.  The only way seems to be
> > to close and restart gitk.  Looks like a bug.
> > 
> > 
> 
> Apparently, gitk rereads the refs but not commits it has read already -
> and the commit reading includes the notes lookup.
> 
> Unfortunately, my wish-fu is lacking. But I'll cc the master.
> 
> Paulus: None of updatecommits, reloadcommits and rereadrefs seem to
> reread the notes of a commit that has been displayed already if the
> notes have changed (but the other refs have not).

As far as shift-F5/reloadcommits is concerned, it looks like I should
be unsetting commitinfo in reloadcommits.

However, I agree gitk should refresh the notes in updatecommits as
well, but that will take more work.  Is git notes list the best way to
find out all the current notes?

Paul.

  reply	other threads:[~2015-04-11 10:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02 19:34 gitk won't show notes? Phillip Susi
2015-04-07 13:40 ` Michael J Gruber
2015-04-07 14:06   ` Phillip Susi
2015-04-07 14:13     ` Michael J Gruber
2015-04-07 17:08       ` Phillip Susi
2015-04-08 11:51         ` Michael J Gruber
2015-04-11 10:31           ` Paul Mackerras [this message]
2015-04-14 12:17             ` Christian Couder
2015-04-14 20:53               ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150411103156.GA5781@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=psusi@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).