gitk won't show notes?

gitk won't show notes?

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I can't seem to get gitk to show notes, even when I give it --notes.
Does it just not handle notes?

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVHZm5AAoJENRVrw2cjl5RT0wIAJVfE2cDQODUCoOsIwhVDiMf
CNeTKy1VxCgwVy8KDoYxY2hBlDIRELkcVIkN5ueNVu57LZ+1z/iBUhgr3mmzH9br
z2viRjkKRlNSqP/b+HwK0+GxBIbN/FpIEyKTPe558SMcUjCkeINfxfcgYYbmY4Rv
aY60j4LMQCEgltkmyDJ/kRX1I7Pr4YCfwNfoIQj3LxvCY5WL7VGn7QmM56Qh9m8P
DVvTdMHBnhLOTCSa79/uAAZKJxVNE7z8YnHw1aimNXs/uwm7DYl4coxXVGDxyUfm
DnEDcqtLfFst58UtLDRn7f3YawT7heeeXJ7tKUAizX3YQuTTRp9WrN12yE7Crxo=
=Z23X
-----END PGP SIGNATURE-----

Re: gitk won't show notes?

[Michael J Gruber]

Phillip Susi venit, vidit, dixit 02.04.2015 21:34:
> I can't seem to get gitk to show notes, even when I give it --notes.
> Does it just not handle notes?
> 
> 

Have you tried with "--show-notes"?

It works over here even without --show-notes, by the way, but I'm not on
Windows. Are you?

Michael

Re: gitk won't show notes?

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/7/2015 9:40 AM, Michael J Gruber wrote:
> Phillip Susi venit, vidit, dixit 02.04.2015 21:34:
>> I can't seem to get gitk to show notes, even when I give it
>> --notes. Does it just not handle notes?
>> 
>> 
> 
> Have you tried with "--show-notes"?
> 
> It works over here even without --show-notes, by the way, but I'm
> not on Windows. Are you?

Yes... and this just got weird... I shutdown and restarted gitk and
now they show up just fine.  It seems that adding the note while gitk
is already open, and hitting refresh fails to detect the note.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVI+R5AAoJENRVrw2cjl5RtnoH/RzJRU/FWrRKc+9P2V5OmR2p
bAto0W92AwQVj4jDL3ndmkgm/RivYwNGYXuRVpLXPjKc0bgKNx8a/w4slnoPiWfv
HFdIRXGWiJmTLhkzTYHlFLx6uZiDcsz5MV0IW1FhVvqa+QcViTS95yZXtzMj9aj5
g6w1h8C3NU+XBQNf9mDS7a6Xwd3+TZfXQJT1CQasTlgvHefzCk0aLU8K0G09N1ld
3XRGY6cCKplEn5CUDuiMLRAiq7XVWpufV0zmT9ZV7h2ZCcY8b9yav/rQPVd5L1cF
PIagJwyZ6YTR/EAGiVU6w0HZemiXHeXTMNMfv4GCRxGwINtfVzmxhnuD5IvKVZk=
=b8Ql
-----END PGP SIGNATURE-----

Re: gitk won't show notes?

[Michael J Gruber]

Phillip Susi venit, vidit, dixit 07.04.2015 16:06:
> On 4/7/2015 9:40 AM, Michael J Gruber wrote:
>> Phillip Susi venit, vidit, dixit 02.04.2015 21:34:
>>> I can't seem to get gitk to show notes, even when I give it
>>> --notes. Does it just not handle notes?
>>>
>>>
> 
>> Have you tried with "--show-notes"?
> 
>> It works over here even without --show-notes, by the way, but I'm
>> not on Windows. Are you?
> 
> Yes... and this just got weird... I shutdown and restarted gitk and
> now they show up just fine.  It seems that adding the note while gitk
> is already open, and hitting refresh fails to detect the note.

Rebooting is the Windows version of refresh ;)

Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the
latter is the thorougher refreshment.

Michael

Re: gitk won't show notes?

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/7/2015 10:13 AM, Michael J Gruber wrote:
> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the 
> latter is the thorougher refreshment.

Neither one makes newly added notes show up.  The only way seems to be
to close and restart gitk.  Looks like a bug.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)

iQEcBAEBAgAGBQJVJA8KAAoJENRVrw2cjl5RrIgH/2FTWanl7IUyusBMmwR5buLP
R0yVGf0xF6xzG3SmayDh9EzmhoSJDBFjbqlb8mG1pbgMQfRNKaCjnlk97WRQ5qDr
X9CHImC4HODZVT/jAgCX5HsCEN62nIZBUfliQOH3PFbbAp6LG/Y/milZk3Ek+srL
guFFzFsCyv88uAjDJMMM4Ub9Sg3rtKckZ2JeprNv8VDFuqvZWxRPA3G+7TYSTBdE
wj73xIjyg0KVP1yAR/833TF7srDaRUnB3Z/AfDXAhekYum5TZnEZNQUh1DpiAnus
dC6T8LWu14PebzmiZy+7QV3cakhlt9ZjrHW9eRBVzY7RAm8JRY1GSgbCQJ0pIQo=
=EWg/
-----END PGP SIGNATURE-----

Re: gitk won't show notes?

[Michael J Gruber]

Phillip Susi venit, vidit, dixit 07.04.2015 19:08:
> On 4/7/2015 10:13 AM, Michael J Gruber wrote:
>> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the 
>> latter is the thorougher refreshment.
> 
> Neither one makes newly added notes show up.  The only way seems to be
> to close and restart gitk.  Looks like a bug.
> 
> 

Apparently, gitk rereads the refs but not commits it has read already -
and the commit reading includes the notes lookup.

Unfortunately, my wish-fu is lacking. But I'll cc the master.

Paulus: None of updatecommits, reloadcommits and rereadrefs seem to
reread the notes of a commit that has been displayed already if the
notes have changed (but the other refs have not).

Michael

Re: gitk won't show notes?

[Paul Mackerras]

On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote:
> Phillip Susi venit, vidit, dixit 07.04.2015 19:08:
> > On 4/7/2015 10:13 AM, Michael J Gruber wrote:
> >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the 
> >> latter is the thorougher refreshment.
> > 
> > Neither one makes newly added notes show up.  The only way seems to be
> > to close and restart gitk.  Looks like a bug.
> > 
> > 
> 
> Apparently, gitk rereads the refs but not commits it has read already -
> and the commit reading includes the notes lookup.
> 
> Unfortunately, my wish-fu is lacking. But I'll cc the master.
> 
> Paulus: None of updatecommits, reloadcommits and rereadrefs seem to
> reread the notes of a commit that has been displayed already if the
> notes have changed (but the other refs have not).

As far as shift-F5/reloadcommits is concerned, it looks like I should
be unsetting commitinfo in reloadcommits.

However, I agree gitk should refresh the notes in updatecommits as
well, but that will take more work.  Is git notes list the best way to
find out all the current notes?

Paul.

Re: gitk won't show notes?

[Christian Couder]

On Sat, Apr 11, 2015 at 12:31 PM, Paul Mackerras <paulus@samba.org> wrote:
> On Wed, Apr 08, 2015 at 01:51:40PM +0200, Michael J Gruber wrote:
>> Phillip Susi venit, vidit, dixit 07.04.2015 19:08:
>> > On 4/7/2015 10:13 AM, Michael J Gruber wrote:
>> >> Seriously: gitk knows F5 and Shift-F5 for refresh, and I think the
>> >> latter is the thorougher refreshment.
>> >
>> > Neither one makes newly added notes show up.  The only way seems to be
>> > to close and restart gitk.  Looks like a bug.
>> >
>> >
>>
>> Apparently, gitk rereads the refs but not commits it has read already -
>> and the commit reading includes the notes lookup.
>>
>> Unfortunately, my wish-fu is lacking. But I'll cc the master.
>>
>> Paulus: None of updatecommits, reloadcommits and rereadrefs seem to
>> reread the notes of a commit that has been displayed already if the
>> notes have changed (but the other refs have not).
>
> As far as shift-F5/reloadcommits is concerned, it looks like I should
> be unsetting commitinfo in reloadcommits.
>
> However, I agree gitk should refresh the notes in updatecommits as
> well, but that will take more work.  Is git notes list the best way to
> find out all the current notes?

It looks like it is from the documentation.
Anyway let's add some people in Cc in case they could help.

Re: gitk won't show notes?

[Johan Herland]

On Tue, Apr 14, 2015 at 2:17 PM, Christian Couder
<christian.couder@gmail.com> wrote:
> On Sat, Apr 11, 2015 at 12:31 PM, Paul Mackerras <paulus@samba.org> wrote:
>> However, I agree gitk should refresh the notes in updatecommits as
>> well, but that will take more work.  Is git notes list the best way to
>> find out all the current notes?

Yes. (if not, that's a bug and should be fixed).

...Johan

>
> It looks like it is from the documentation.
> Anyway let's add some people in Cc in case they could help.



-- 
Johan Herland, <johan@herland.net>
www.herland.net