From: Luke Mewburn <luke@mewburn.net>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Luke Mewburn <luke@mewburn.net>, Nicolas Pitre <nico@fluxnic.net>,
git@vger.kernel.org, msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp()
Date: Fri, 17 Apr 2015 11:25:41 +1000 [thread overview]
Message-ID: <20150417012541.GI23475@mewburn.net> (raw)
In-Reply-To: <552EAE0A.3040208@kdbg.org>
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
On Wed, Apr 15, 2015 at 08:29:30PM +0200, Johannes Sixt wrote:
| Windows does not have process groups. It is, therefore, the simplest
| to pretend that each process is in its own process group.
|
| [...]
|
| diff --git a/compat/mingw.h b/compat/mingw.h
| index 7b523cf..a552026 100644
| @@ -118,6 +116,12 @@ static inline int sigaddset(sigset_t *set, int signum)
| #define SIG_UNBLOCK 0
| static inline int sigprocmask(int how, const sigset_t *set, sigset_t *oldset)
| { return 0; }
| +static inline pid_t getppid(void)
| +{ return 1; }
| +static inline pid_t getpgid(pid_t pid)
| +{ return pid == 0 ? getpid() : pid; }
| +static inline pid_t tcgetpgrp(int fd)
| +{ return getpid(); }
This appears to be similar to the approach that tcsh uses too;
return the current process ID for the process group ID.
See https://github.com/tcsh-org/tcsh/blob/master/win32/ntport.h
for tcsh's implementation of getpgrp() (a variation of getpgid())
and tcgetpgrp().
regards,
Luke.
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-04-17 1:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 13:48 [PATCH] reduce progress updates in background Luke Mewburn
2015-04-13 14:11 ` Nicolas Pitre
2015-04-13 14:40 ` Luke Mewburn
2015-04-13 15:01 ` Nicolas Pitre
2015-04-14 11:03 ` [PATCH v2] " Luke Mewburn
2015-04-14 15:16 ` Nicolas Pitre
2015-04-15 18:29 ` [PATCH] compat/mingw: stubs for getpgid() and tcgetpgrp() Johannes Sixt
2015-04-15 18:48 ` Junio C Hamano
2015-04-15 20:34 ` Johannes Sixt
2015-04-16 12:48 ` Johannes Schindelin
2015-04-16 15:00 ` Junio C Hamano
2015-04-15 19:43 ` Erik Faye-Lund
2015-04-16 12:44 ` [msysGit] " Johannes Schindelin
2015-04-23 19:25 ` rupert thurner
2015-04-24 3:03 ` rupert thurner
2015-04-24 6:25 ` [msysGit] " Johannes Schindelin
2015-04-17 1:25 ` Luke Mewburn [this message]
2015-04-14 11:08 ` [PATCH] reduce progress updates in background Luke Mewburn
2015-04-14 3:12 ` brian m. carlson
2015-04-14 8:47 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417012541.GI23475@mewburn.net \
--to=luke@mewburn.net \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=msysgit@googlegroups.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).