git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	git@vger.kernel.org, "Joshua Jensen" <jjensen@workspacewhiz.com>,
	"Jonathan Nieder" <jrnieder@gmail.com>
Subject: Re: [PATCH] fast-import: add options to enable/disable case folding
Date: Sat, 18 Apr 2015 16:36:11 +0900	[thread overview]
Message-ID: <20150418073611.GA13410@glandium.org> (raw)
In-Reply-To: <xmqqwq1appcf.fsf@gitster.dls.corp.google.com>

On Fri, Apr 17, 2015 at 11:44:00AM -0700, Junio C Hamano wrote:
> So perhaps we should rip the case folding out altogether instead?
> The entry for the change in the Release Notes may say:
> 
>  * "git fast-import" incorrectly case-folded the paths recorded in
>    the history when core.ignorease is set (i.e. the repository's
>    working tree is incapable of expressing paths that differ only in
>    their cases); this old bug was reported in 2012 and was finally
>    corrected.
> 
> or something like that?

Is anything else then git-p4 known to rely on case folding? If not, I
guess that's a reasonable plan. We could even add an option to
fast-import that would allow to turn case folding back on, and make
git-p4 use it, so that its expectations are fulfilled. Although at some
point, it could (should?) do case folding itself(?)

Mike

  reply	other threads:[~2015-04-18  7:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09  0:12 fast-import should not care about core.ignorecase Mike Hommey
2014-12-09  0:22 ` Mike Hommey
2014-12-09  1:07 ` Joshua Jensen
2014-12-09  1:31   ` Jonathan Nieder
2014-12-09  3:20     ` Joshua Jensen
2014-12-09 20:19       ` Junio C Hamano
2015-04-17 11:52         ` [PATCH] fast-import: add options to enable/disable case folding Mike Hommey
2015-04-17 16:56           ` Torsten Bögershausen
2015-04-17 18:44             ` Junio C Hamano
2015-04-18  7:36               ` Mike Hommey [this message]
2015-04-24  9:42                 ` Luke Diamand
2015-04-17 19:57             ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150418073611.GA13410@glandium.org \
    --to=mh@glandium.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jjensen@workspacewhiz.com \
    --cc=jrnieder@gmail.com \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).