From: Charles Bailey <charles@hashpling.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Karthik Nayak <karthik.188@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
"sunshine@sunshineco.com" <sunshine@sunshineco.com>
Subject: Re: [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option
Date: Mon, 20 Apr 2015 08:44:34 +0100 [thread overview]
Message-ID: <20150420074433.GA30422@hashpling.org> (raw)
In-Reply-To: <xmqq7ft7nz8l.fsf@gitster.dls.corp.google.com>
> On 20 Apr 2015, at 06:30, Junio C Hamano <gitster@pobox.com> wrote:
> Charles Bailey <charles@hashpling.org> writes:
>
>> The option isn't a true opposite of hash-object's --literally because
>> that also allows the creation of known types with invalid contents (e.g.
>> corrupt trees) whereas cat-file is quite happy to show the _contents_ of
>> such corrupt objects even without --literally.
>
> Not really. If you create an object with corrupt type string (e.g. "BLOB"
> instead of "blob"), cat-file would not be happy.
Sorry, the emphasis should have been on "complete" of "complete
opposite". There are some types of bad objects that can be created only
with hash-object --literally (malformed tag or tree), for which cat-file
works with fine and there are other types (pun unintended - BLOB,
wobble, etc.) for which --literally/--unchecked is required with
cat-file.
So I meant that cat-file's --literally is only a partial "opposite" or
analogue of hash-object's.
--allow-invalid-types? --force (in the sense of "suppress some possible
errors")? It's not a big thing but I'm aware that if we can find a better
name then now would be the best moment. If not, then --literally it is.
next prev parent reply other threads:[~2015-04-20 7:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 16:55 [PATCH v8 0/4] cat-file: teach cat-file a '--literally' option karthik nayak
2015-04-15 16:59 ` [PATCH v8 1/4] sha1_file.c: support reading from a loose object of unknown type Karthik Nayak
2015-04-15 20:21 ` Junio C Hamano
2015-04-15 22:18 ` Jeff King
2015-04-17 14:23 ` Jeff King
2015-04-17 16:21 ` Junio C Hamano
2015-04-17 20:51 ` Jeff King
2015-04-17 21:10 ` Junio C Hamano
2015-04-20 18:43 ` karthik nayak
2015-04-20 18:51 ` Jeff King
2015-04-21 11:26 ` karthik nayak
2015-04-21 14:24 ` Jeff King
2015-04-17 18:45 ` karthik nayak
2015-04-17 18:49 ` Jeff King
2015-04-18 8:31 ` karthik nayak
2015-04-17 19:23 ` Junio C Hamano
2015-04-18 8:32 ` karthik nayak
2015-04-17 23:31 ` Eric Sunshine
2015-04-18 9:03 ` karthik nayak
2015-04-15 16:59 ` [PATCH v8 2/4] cat-file: teach cat-file a '--literally' option Karthik Nayak
2015-04-15 20:20 ` Junio C Hamano
2015-04-15 20:52 ` Junio C Hamano
2015-04-16 7:26 ` karthik nayak
2015-04-16 13:35 ` Junio C Hamano
2015-04-17 2:10 ` Karthik Nayak
2015-04-17 2:14 ` Junio C Hamano
2015-04-19 0:28 ` Charles Bailey
2015-04-20 5:30 ` Junio C Hamano
2015-04-20 7:44 ` Charles Bailey [this message]
2015-04-20 8:57 ` Karthik Nayak
2015-04-20 9:19 ` Charles Bailey
2015-04-20 15:52 ` karthik nayak
2015-04-21 10:16 ` Charles Bailey
2015-04-21 19:40 ` Eric Sunshine
2015-04-21 20:36 ` Junio C Hamano
2015-04-25 11:22 ` karthik nayak
2015-04-25 17:04 ` Junio C Hamano
2015-04-27 11:57 ` karthik nayak
2015-04-27 18:38 ` Eric Sunshine
2015-04-28 12:03 ` karthik nayak
2015-04-15 17:00 ` [PATCH v8 3/4] cat-file: add documentation for " Karthik Nayak
2015-04-15 17:00 ` [PATCH v8 4/4] t1006: add tests for git cat-file --literally Karthik Nayak
2015-04-18 0:00 ` Eric Sunshine
2015-04-18 5:22 ` karthik nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420074433.GA30422@hashpling.org \
--to=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).