From: Jeff King <peff@peff.net>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] t7502-commit.sh: fix a broken and-chain
Date: Tue, 28 Apr 2015 22:11:33 -0400 [thread overview]
Message-ID: <20150429021132.GA438@peff.net> (raw)
In-Reply-To: <553F775C.3030102@ramsay1.demon.co.uk>
On Tue, Apr 28, 2015 at 01:04:44PM +0100, Ramsay Jones wrote:
> This test recently started failing for me. I haven't heard anyone
> else complaining about this, so maybe I should look into why my
> environment may be different to everyone else ... :-D (when I can
> find some time, of course!)
>
> [...]
> test_expect_success !AUTOIDENT 'do not fire editor when committer is bogus' '
> - >.git/result
> + >.git/result &&
It looks like 92b269f (test-lib: turn on GIT_TEST_CHAIN_LINT by default,
2015-04-22) made it into pu recently, so you are probably just the first
person to test it whose system matches !AUTOIDENT (which in turn is
based on things like whether we can come up with a plausible-looking
email from your system).
Patch itself is obviously correct, and it looks like Junio has already
picked it up for pu. Thanks.
-Peff
prev parent reply other threads:[~2015-04-29 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 12:04 [PATCH] t7502-commit.sh: fix a broken and-chain Ramsay Jones
2015-04-29 2:11 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429021132.GA438@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).