git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2015, #04; Mon, 27)
Date: Wed, 29 Apr 2015 21:02:56 -0400	[thread overview]
Message-ID: <20150430010256.GA5089@peff.net> (raw)
In-Reply-To: <xmqqbni64kum.fsf@gitster.dls.corp.google.com>

On Wed, Apr 29, 2015 at 03:42:57PM -0700, Junio C Hamano wrote:

> > * jk/at-push-sha1 (2015-03-31) 6 commits
> >  - sha1_name: implement @{push} shorthand
> >  - sha1_name: refactor upstream_mark
> >  - remote.c: provide per-branch pushremote name
> >  - remote.c: hoist branch.*.remote lookup out of remote_get_1
> >  - remote.c: drop "remote" pointer from "struct branch"
> >  - remote.c: drop default_remote_name variable
> >
> >  Introduce <branch>@{push} short-hand to denote the remote-tracking
> >  branch that tracks the branch at the remote the <branch> would be
> >  pushed to.
> >
> >  Waiting for a reroll ($gmane/266573).

I re-rolled this and _almost_ sent it out last week. But I noticed that
it gives us only "git rev-parse foo@{push}" and not "git for-each-ref
--format=%(push)" (whereas we have "upstream" for both versions). For
"upstream", computing the answer is simple enough that the tiny bit of
logic is largely duplicated in the two spots. For @{push}, that would be
a bad idea. So I started refactoring the final patch to use the same
logic in both spots, but didn't finish.

I can send the intermediate version (i.e., the re-roll with a few minor
fixups based on list comments), and we can build the other on top, but I
don't think there's any rush, and it can wait for the refactor (which
shouldn't be _too_ bad, I don't think).

-Peff

  parent reply	other threads:[~2015-04-30  1:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 20:01 What's cooking in git.git (Apr 2015, #04; Mon, 27) Junio C Hamano
2015-04-29 22:42 ` Junio C Hamano
2015-04-29 22:50   ` Koosha Khajehmoogahi
2015-04-30  1:38     ` Junio C Hamano
2015-04-30  0:18   ` Paul Tan
2015-04-30  1:37     ` Junio C Hamano
2015-04-30  1:02   ` Jeff King [this message]
2015-04-30  1:36     ` Junio C Hamano
2015-04-30  6:55   ` Michael Haggerty
2015-04-30  8:00   ` Michael J Gruber
2015-04-30  8:21   ` Michael Haggerty
2015-04-30  1:07 ` Duy Nguyen
2015-04-30  1:35   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430010256.GA5089@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).