From: Jeff King <peff@peff.net>
To: Junio C Hamano <junio@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t5540: skip under NO_CURL=NoThanks
Date: Wed, 6 May 2015 13:32:00 -0400 [thread overview]
Message-ID: <20150506173200.GA7985@peff.net> (raw)
In-Reply-To: <xmqq6185d4o1.fsf@gitster.dls.corp.google.com>
On Wed, May 06, 2015 at 09:58:06AM -0700, Junio C Hamano wrote:
> All the other tests in t5xxx series that require http support check
> NO_CURL and skip the test, but this one forgot to do so.
Makes sense, though I wonder if this check should just get pushed into
lib-httpd.sh. Surely we can't do anything useful with a web server we
started if we have no curl support? And this seems to support the case:
$ comm -23 <(git grep -l lib-httpd.sh) <(git grep -l NO_CURL)
lib-httpd.sh
t5540-http-push-webdav.sh
After your patch, there is literally no script which includes
lib-httpd.sh but does not respect NO_CURL.
-Peff
next prev parent reply other threads:[~2015-05-06 17:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 16:58 [PATCH] t5540: skip under NO_CURL=NoThanks Junio C Hamano
2015-05-06 17:32 ` Jeff King [this message]
2015-05-06 17:42 ` Jeff King
2015-05-06 18:49 ` Junio C Hamano
2015-05-07 16:06 ` [PATCH] tests: skip dav http-push tests under NO_EXPAT=NoThanks Junio C Hamano
2015-05-07 16:13 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506173200.GA7985@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).