From: Jeff King <peff@peff.net>
To: John Keeping <john@keeping.me.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
Jean-Noel Avila <jn.avila@free.fr>,
git@vger.kernel.org
Subject: Re: [PATCH 6/8] doc: convert \--option to --option
Date: Thu, 14 May 2015 00:32:59 -0400 [thread overview]
Message-ID: <20150514043259.GC9351@peff.net> (raw)
In-Reply-To: <20150513094841.GA10518@serenity.lan>
On Wed, May 13, 2015 at 10:48:42AM +0100, John Keeping wrote:
> On Wed, May 13, 2015 at 01:01:38AM -0400, Jeff King wrote:
> > Older versions of AsciiDoc would convert the "--" in
> > "--option" into an emdash. According to 565e135
> > (Documentation: quote double-dash for AsciiDoc, 2011-06-29),
> > this is fixed in AsciiDoc 8.3.0. According to bf17126, we
> > don't support anything older than 8.4.1 anyway, so we no
> > longer need to worry about quoting.
> >
> > Even though this does not change the output at all, there
> > are a few good reasons to drop the quoting:
> >
> > 1. It makes the source prettier to read.
> >
> > 2. We don't quote consistently, which may be confusing when
> > reading the source.
> >
> > 3. Asciidoctor does not like the quoting, and renders a
> > literal backslash.
>
> If we're changing all of these files anyway, it would be nice to wrap
> literal options in backticks as suggested in
> Documentation/CodingGuidelines.
I considered it, and I do prefer backticks. But I stopped short because
my goal here was to make source changes that didn't have any actual
output changes. So I'm not opposed to the output change, but it doesn't
belong in this patch.
I'm also a little hesitant just because it semes there are quite a lot
of outliers. I'm not sure if I'm helping anything to produce a patch
that changes a small subset of them (i.e., if we do it, we should really
do it thoroughly).
I dunno. If you want to do a patch on top, I'd be happy to look at it.
-Peff
next prev parent reply other threads:[~2015-05-14 4:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:23 [PATCH] doc: fix unmatched code fences Jean-Noel Avila
2015-05-12 18:45 ` Junio C Hamano
2015-05-13 2:15 ` Jeff King
2015-05-13 3:43 ` Junio C Hamano
2015-05-13 3:45 ` Jeff King
2015-05-13 4:32 ` Junio C Hamano
2015-05-13 4:36 ` Jeff King
2015-05-13 22:22 ` brian m. carlson
2015-05-13 4:56 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 4:57 ` [PATCH 1/8] doc: fix misrendering due to `single quote' Jeff King
2015-05-13 4:58 ` [PATCH 2/8] doc: fix unquoted use of "{type}" Jeff King
2015-05-13 4:58 ` [PATCH 3/8] doc: fix hanging "+"-continuation Jeff King
2015-05-13 4:58 ` [PATCH 4/8] doc: fix length of underlined section-title Jeff King
2015-05-13 4:58 ` [PATCH 5/8] doc/add: reformat `--edit` option Jeff King
2015-05-13 5:01 ` [PATCH 6/8] doc: convert \--option to --option Jeff King
2015-05-13 9:48 ` John Keeping
2015-05-14 4:32 ` Jeff King [this message]
2015-05-17 18:34 ` Junio C Hamano
2015-05-13 5:02 ` [PATCH 7/8] doc: drop backslash quoting of some curly braces Jeff King
2015-05-13 5:06 ` [PATCH 8/8] doc: put example URLs and emails inside literal backticks Jeff King
2015-05-13 5:09 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 5:23 ` Junio C Hamano
2015-05-13 5:37 ` Jeff King
2015-05-13 7:43 ` Johannes Schindelin
2015-05-14 4:29 ` Jeff King
2015-05-13 22:41 ` brian m. carlson
2015-05-14 4:25 ` Jeff King
2015-05-14 4:34 ` [PATCH 9/8] doc: convert AsciiDoc {?foo} to ifdef::foo[] Jeff King
2015-05-14 7:43 ` [PATCH 0/8] asciidoc fixups Johannes Schindelin
2015-05-14 17:38 ` Jeff King
2015-05-14 18:20 ` Johannes Schindelin
2015-05-14 21:10 ` Junio C Hamano
2015-05-14 21:17 ` Jeff King
2015-05-14 21:40 ` Junio C Hamano
2015-05-14 21:56 ` David Turner
2015-05-15 2:52 ` brian m. carlson
2015-05-15 4:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514043259.GC9351@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=john@keeping.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).