From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Jean-Noel Avila <jn.avila@free.fr>,
git@vger.kernel.org, David Turner <dturner@twitter.com>
Subject: Re: [PATCH 0/8] asciidoc fixups
Date: Thu, 14 May 2015 17:17:27 -0400 [thread overview]
Message-ID: <20150514211727.GA15528@peff.net> (raw)
In-Reply-To: <xmqqwq0aj25e.fsf@gitster.dls.corp.google.com>
On Thu, May 14, 2015 at 02:10:53PM -0700, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>
> >> My asciidoctor just comes from the Debian package. Looks like it's over
> >> a year old at this point. I should probably be testing with something
> >> more recent.
> >
> > We installed asciidoctor via `gem` and have version 1.5.2.
>
> What I'll be pushing out today will have some "interesting" mark-up
> in Documentation/git-cat-file.txt (on 'jch' or 'pu') from David's
> '--follow-symlinks' topic. I think AsciiDoc formatting looks OK,
> but can you check it with both older (peff) and newer (dscho)
> asciidoctor to see how well it shows? Look for --follow-symlinks
> in the output.
What's in 366bc15e9 (your SQUASH) looks terrible with older asciidoctor.
The "[normal]" bumps us out of the list item, left-aligning all of the
other paragraphs, and then the "+" continuation is treated literally
(probably because we are not inside a block).
I don't see any reason we cannot use normal "+" continuation here (but
the hanging paragraphs need to be left-aligned, then).
-Peff
next prev parent reply other threads:[~2015-05-14 21:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 17:23 [PATCH] doc: fix unmatched code fences Jean-Noel Avila
2015-05-12 18:45 ` Junio C Hamano
2015-05-13 2:15 ` Jeff King
2015-05-13 3:43 ` Junio C Hamano
2015-05-13 3:45 ` Jeff King
2015-05-13 4:32 ` Junio C Hamano
2015-05-13 4:36 ` Jeff King
2015-05-13 22:22 ` brian m. carlson
2015-05-13 4:56 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 4:57 ` [PATCH 1/8] doc: fix misrendering due to `single quote' Jeff King
2015-05-13 4:58 ` [PATCH 2/8] doc: fix unquoted use of "{type}" Jeff King
2015-05-13 4:58 ` [PATCH 3/8] doc: fix hanging "+"-continuation Jeff King
2015-05-13 4:58 ` [PATCH 4/8] doc: fix length of underlined section-title Jeff King
2015-05-13 4:58 ` [PATCH 5/8] doc/add: reformat `--edit` option Jeff King
2015-05-13 5:01 ` [PATCH 6/8] doc: convert \--option to --option Jeff King
2015-05-13 9:48 ` John Keeping
2015-05-14 4:32 ` Jeff King
2015-05-17 18:34 ` Junio C Hamano
2015-05-13 5:02 ` [PATCH 7/8] doc: drop backslash quoting of some curly braces Jeff King
2015-05-13 5:06 ` [PATCH 8/8] doc: put example URLs and emails inside literal backticks Jeff King
2015-05-13 5:09 ` [PATCH 0/8] asciidoc fixups Jeff King
2015-05-13 5:23 ` Junio C Hamano
2015-05-13 5:37 ` Jeff King
2015-05-13 7:43 ` Johannes Schindelin
2015-05-14 4:29 ` Jeff King
2015-05-13 22:41 ` brian m. carlson
2015-05-14 4:25 ` Jeff King
2015-05-14 4:34 ` [PATCH 9/8] doc: convert AsciiDoc {?foo} to ifdef::foo[] Jeff King
2015-05-14 7:43 ` [PATCH 0/8] asciidoc fixups Johannes Schindelin
2015-05-14 17:38 ` Jeff King
2015-05-14 18:20 ` Johannes Schindelin
2015-05-14 21:10 ` Junio C Hamano
2015-05-14 21:17 ` Jeff King [this message]
2015-05-14 21:40 ` Junio C Hamano
2015-05-14 21:56 ` David Turner
2015-05-15 2:52 ` brian m. carlson
2015-05-15 4:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150514211727.GA15528@peff.net \
--to=peff@peff.net \
--cc=dturner@twitter.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=johannes.schindelin@gmx.de \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).