Git development
 help / color / mirror / Atom feed
From: Jim Hill <gjthill@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_file: pass empty buffer to index empty file
Date: Thu, 14 May 2015 16:26:40 -0700	[thread overview]
Message-ID: <20150514232640.GA11838@gadabout.domain.actdsltmp> (raw)
In-Reply-To: <xmqqbnhnknio.fsf@gitster.dls.corp.google.com>

Thanks for the corrections and improvements. The resulting test code
looks much cleaner to me.

Please do suggest any further improvements that occur to you,

Thanks,
Jim

      parent reply	other threads:[~2015-05-14 23:26 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 17:23 [PATCH] sha1_file: pass empty buffer to index empty file Jim Hill
2015-05-14 18:43 ` Junio C Hamano
2015-05-14 23:17   ` [PATCH v2] " Jim Hill
2015-05-15 18:01     ` Junio C Hamano
2015-05-15 23:31       ` Jim Hill
2015-05-16 18:48         ` Junio C Hamano
2015-05-16 20:06           ` [PATCH v3] " Jim Hill
2015-05-16 23:22             ` Junio C Hamano
2015-05-17 17:37             ` Junio C Hamano
2015-05-17 19:10               ` Junio C Hamano
2015-05-18  0:41                 ` [PATCH v4] " Jim Hill
2015-05-19  6:37                 ` [PATCH v3] " Jeff King
2015-05-19 18:11                   ` Junio C Hamano
2015-05-19 18:17                     ` Junio C Hamano
2015-05-19 18:35                       ` Junio C Hamano
2015-05-19 19:48                         ` Junio C Hamano
2015-05-19 22:14                           ` Jeff King
2015-05-20 17:03                             ` Junio C Hamano
2015-05-19 19:40                     ` Eric Sunshine
2015-05-19 22:09                     ` Jeff King
2015-05-20 17:25                       ` Junio C Hamano
2015-05-20 17:38                         ` Jeff King
2015-05-14 23:26   ` Jim Hill [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150514232640.GA11838@gadabout.domain.actdsltmp \
    --to=gjthill@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox