From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jens Lehmann <Jens.Lehmann@web.de>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] subdirectory tests: code cleanup, uncomment test
Date: Mon, 18 May 2015 15:03:19 -0700 [thread overview]
Message-ID: <20150518220318.GE5586@google.com> (raw)
In-Reply-To: <CAGZ79kZ9h=Oev_mymFBRNyAGokAe8-vWh_D12VZYHTUv20Djvg@mail.gmail.com>
Stefan Beller wrote:
> I am not happy with (historic) either, maybe "(explicit GIT_DIR)"
> is describing the test better without giving the reader the thoughts
> as you raised here?
The general principle I use is to try to briefly describe what
hypothesis the code is trying to test, so that if it fails someone knows
what that means.
In this case, I could do
test_expect_success 'no file/rev ambiguity with explicit GIT_DIR=.' '
[...]
>>> cd foo.git &&
>>> + # older Git needed help by exporting GIT_DIR=.
>>> + # to realize that it is inside a bare repository.
>>> + # We keep this test around for regression testing.
>>> GIT_DIR=. git show -s HEAD
I don't think this comment is needed, since it doesn't make it clearer
what the test is about.
Thanks,
Jonathan
next prev parent reply other threads:[~2015-05-18 22:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 18:13 [PATCH] t1020: cleanup subdirectory tests a little Stefan Beller
2015-05-18 18:29 ` Junio C Hamano
2015-05-18 18:30 ` Junio C Hamano
2015-05-18 18:36 ` Stefan Beller
2015-05-18 19:08 ` Junio C Hamano
2015-05-18 21:10 ` [PATCH] subdirectory tests: code cleanup, uncomment test Stefan Beller
2015-05-18 21:21 ` Junio C Hamano
2015-05-18 21:29 ` Stefan Beller
2015-05-18 22:03 ` Jonathan Nieder [this message]
2015-05-19 21:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518220318.GE5586@google.com \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).