git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Aguilar <davvid@gmail.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: "SZEDER Gábor" <szeder@ira.uka.de>,
	"Phil Susi" <phillsusi@gmail.com>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Philip Oakley" <philipoakley@iee.org>,
	"Johannes Schindelin" <johannes.schindelin@gmx.de>,
	"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH v2] mergetools: add winmerge as a builtin tool
Date: Tue, 19 May 2015 21:10:23 -0700	[thread overview]
Message-ID: <20150520041017.GA91560@gmail.com> (raw)
In-Reply-To: <CAHGBnuNvTZ27CCquHHtC5bQFkG2k-+SDYw-6U2TRzzHyFiFwJw@mail.gmail.com>

On Fri, May 15, 2015 at 07:40:53AM +0200, Sebastian Schuberth wrote:
> On Thu, May 14, 2015 at 11:24 PM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> 
> >> $ echo "$PROGRAMFILES(X86)"
> >> C:\Program Files (x86)(X86)
> >>
> >> So it seems to resolve only the $PROGRAMFILES part and appending the
> >> literal "(X86)". Not sure how to tell Bash that "(X86)" is part of the
> >> variable name.
> >
> > It would be ${PROGRAMFILES(X86)}, but POSIX says that variable names can
> > only contain alphanumeric characters and underscores, and Bash adheres
> > when it complains about it in Johannes' example above.  Not sure whether
> > there is a clever escaping that could make it work, I couldn't find any.
> 
> Right, I did already try that curly-braces-style of quoting, and
> MSYS1/2 both give:
> 
> $ echo ${PROGRAMFILES(X86)}
> sh.exe": ${PROGRAMFILES(X86)}: bad substitution
> 
> I couldn't find any other style of quoting that works, either.

How about simply "$PROGRAMFILES (x86)"?

Let the shell handle the programfiles part, and then it'll
concat the (x86).  That's what's on the filesystem anyways, so
it should DTRT.  I'll send this in patch form shortly.
-- 
David

      reply	other threads:[~2015-05-20  4:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  2:00 [PATCH v2] mergetools: add winmerge as a builtin tool David Aguilar
2015-05-13  8:10 ` Johannes Schindelin
2015-05-13 13:19 ` Sebastian Schuberth
2015-05-13 15:22   ` Johannes Schindelin
2015-05-13 15:33     ` Sebastian Schuberth
2015-05-13 20:00       ` Sebastian Schuberth
2015-05-13 20:36         ` Sebastian Schuberth
2015-05-13 20:37           ` Sebastian Schuberth
2015-05-14 21:48             ` SZEDER Gábor
2015-05-15  5:46               ` Sebastian Schuberth
2015-05-15  9:01                 ` SZEDER Gábor
2015-05-14 21:24       ` SZEDER Gábor
2015-05-15  5:40         ` Sebastian Schuberth
2015-05-20  4:10           ` David Aguilar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520041017.GA91560@gmail.com \
    --to=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=philipoakley@iee.org \
    --cc=phillsusi@gmail.com \
    --cc=sschuberth@gmail.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).