From: Patrick Steinhardt <ps@pks.im>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of "packfile"
Date: Wed, 20 May 2015 07:13:59 +0200 [thread overview]
Message-ID: <20150520051359.GA367@pks-pc.localdomain> (raw)
In-Reply-To: <xmqqwq04745w.fsf@gitster.dls.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]
On Tue, May 19, 2015 at 12:34:03PM -0700, Junio C Hamano wrote:
> There still are a handful of "pack-file" remaining in the
> documentation set, even after applying these three that changes
> 6 instances of 'pack-file' to 'packfile'.
>
> git-index-pack.txt:'git index-pack' [-v] [-o <index-file>] <pack-file>
> git-index-pack.txt: [<pack-file>]
> git-index-pack.txt: instead and a copy is then written to <pack-file>. If
> git-index-pack.txt: <pack-file> is not specified, the pack is written to
> git-index-pack.txt: <pack-file> is not specified consider using --keep to
> git-unpack-objects.txt:'git unpack-objects' [-n] [-q] [-r] [--strict] < <pack-file>
> technical/pack-heuristics.txt: <linus> Anyway, the pack-file could easily be denser still, but
> technical/pack-heuristics.txt: <linus> In particular, while the pack-file is then compressed,
> technical/pack-heuristics.txt: <linus> Anyway: I'm not even trying to claim that the pack-files
> technical/pack-protocol.txt: update-request = *shallow ( command-list | push-cert ) [pack-file]
> technical/pack-protocol.txt: pack-file = "PACK" 28*(OCTET)
> user-manual.txt:[[pack-files]]
>
> A quick "git grep packfile" vs "git grep pack-file" inside
> Documentation/ directory indicates that we seem to use 'packfile'
> primarily in the lower-level technical documents that are not
> end-user facing. Almost half of them are in the release notes
> that we won't bother "fixing", so it might make sense to go the
> other way around, consistently using "pack-file" that may be more
> familiar to end-users.
>
> What do others think?
I was aware of the other instances of 'pack-file'. The only case
where 'pack-file' does occur after my patches, though, was as
command line parameters, where I didn't want to change it. If
that's desired I can whip up another patch.
Patrick
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-05-20 5:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-17 6:56 [PATCH 1/3] git-verify-pack.txt: fix inconsistent spelling of "packfile" Patrick Steinhardt
2015-05-17 6:56 ` [PATCH 2/3] git-unpack-objects.txt: " Patrick Steinhardt
2015-05-17 6:56 ` [PATCH 3/3] pack-protocol.txt: fix insconsistent " Patrick Steinhardt
2015-05-19 19:34 ` [PATCH 1/3] git-verify-pack.txt: fix inconsistent " Junio C Hamano
2015-05-19 22:24 ` Jeff King
2015-05-20 19:22 ` Junio C Hamano
2015-05-20 19:45 ` Junio C Hamano
2015-05-20 19:49 ` Jeff King
2015-05-20 22:37 ` Junio C Hamano
2015-05-21 2:04 ` Jeff King
2015-05-21 4:54 ` Junio C Hamano
2015-05-21 7:27 ` [PATCH] doc: " Patrick Steinhardt
2015-05-21 16:37 ` Junio C Hamano
2015-05-22 6:10 ` Patrick Steinhardt
2015-05-22 6:22 ` [PATCH v2] " Patrick Steinhardt
2015-05-22 16:00 ` Junio C Hamano
2015-05-20 5:13 ` Patrick Steinhardt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520051359.GA367@pks-pc.localdomain \
--to=ps@pks.im \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).