From: David Aguilar <davvid@gmail.com>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: "Phil Susi" <phillsusi@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Philip Oakley" <philipoakley@iee.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH v4] mergetools: add winmerge as a builtin tool
Date: Wed, 20 May 2015 01:53:48 -0700 [thread overview]
Message-ID: <20150520085346.GA99001@gmail.com> (raw)
In-Reply-To: <CAHGBnuMCvzBYRYgLxz-5QJ5x8Quhw6byf+cGteRXQzpU65B+Jg@mail.gmail.com>
On Wed, May 20, 2015 at 09:47:56AM +0200, Sebastian Schuberth wrote:
> On Wed, May 20, 2015 at 9:42 AM, David Aguilar <davvid@gmail.com> wrote:
>
> > + OIFS=$IFS
> > + IFS='
> > +'
>
> I guess this is just a formatting issue with the mail export as it should read
>
> IFS=$'\n'
>
> Otherwise looks good to me.
>
> --
> Sebastian Schuberth
Thanks for the review.
That's actually a literal newline inside a single-quoted string.
I'm not sure how portable $'\n' is, but the '<literal-newline>'
approach is used often in the git code.
--
David
next prev parent reply other threads:[~2015-05-20 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 7:42 [PATCH v4] mergetools: add winmerge as a builtin tool David Aguilar
2015-05-20 7:47 ` Sebastian Schuberth
2015-05-20 8:53 ` David Aguilar [this message]
2015-05-20 20:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150520085346.GA99001@gmail.com \
--to=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=philipoakley@iee.org \
--cc=phillsusi@gmail.com \
--cc=sschuberth@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).