git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: "Stefan Näwe" <stefan.naewe@atlas-elektronik.com>
Subject: [PATCH 3/3] suppress errors on missing UNINTERESTING links
Date: Mon, 1 Jun 2015 05:56:40 -0400	[thread overview]
Message-ID: <20150601095640.GC31389@peff.net> (raw)
In-Reply-To: <20150601095410.GA16976@peff.net>

When we are traversing commit parents along the
UNINTERESTING side of a revision walk, we do not care if
the parent turns out to be missing. That lets us limit
traversals using unreachable and possibly incomplete
sections of history. However, we do still print error
messages about the missing commits; this patch suppresses
the error, as well.

Signed-off-by: Jeff King <peff@peff.net>
---
 revision.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/revision.c b/revision.c
index 29e5143..0b322b4 100644
--- a/revision.c
+++ b/revision.c
@@ -817,7 +817,7 @@ static int add_parents_to_list(struct rev_info *revs, struct commit *commit,
 			parent = parent->next;
 			if (p)
 				p->object.flags |= UNINTERESTING;
-			if (parse_commit(p) < 0)
+			if (parse_commit_gently(p, 1) < 0)
 				continue;
 			if (p->parents)
 				mark_parents_uninteresting(p);
-- 
2.4.2.690.g2a79674

  parent reply	other threads:[~2015-06-01  9:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-01  7:37 git gc gives "error: Could not read..." Stefan Näwe
2015-06-01  8:14 ` Jeff King
2015-06-01  8:40   ` Stefan Näwe
2015-06-01  8:52     ` Jeff King
2015-06-01  9:14       ` Stefan Näwe
2015-06-01  9:58         ` Jeff King
2015-06-01 10:08           ` Stefan Näwe
2015-06-01 10:22             ` Jeff King
2015-06-01  9:54       ` [RFC/PATCH 0/3] silence missing-link warnings in some cases Jeff King
2015-06-01  9:56         ` [PATCH 1/3] add quieter versions of parse_{tree,commit} Jeff King
2015-06-01  9:56         ` [PATCH 2/3] silence broken link warnings with revs->ignore_missing_links Jeff King
2015-06-01  9:56         ` Jeff King [this message]
2015-06-01 15:03         ` [RFC/PATCH 0/3] silence missing-link warnings in some cases Junio C Hamano
2015-06-01 15:41           ` Jeff King
2015-06-01 16:11             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150601095640.GC31389@peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=stefan.naewe@atlas-elektronik.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).