From: Jeff King <peff@peff.net>
To: Jim Hill <gjthill@gmail.com>
Cc: Junio Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] don't add duplicate paths to info/alternates
Date: Mon, 1 Jun 2015 06:53:48 -0400 [thread overview]
Message-ID: <20150601105348.GD31792@peff.net> (raw)
In-Reply-To: <1433096123-14420-1-git-send-email-gjthill@gmail.com>
On Sun, May 31, 2015 at 11:15:21AM -0700, Jim Hill wrote:
> These patches address
> http://thread.gmane.org/gmane.comp.version-control.git/269050/focus=269415
> linked from the git blame page, avoiding adding duplicates to info/alternates
> and removing hold_lock_file_for_append which is too heavyweight for logging and
> too limited for anything else.
Thanks. Mentioning that I would like something done and then having it
unexpectedly arrive in my mailbox is like getting a present. :)
I had a few comments on the first patch, and the second looks obviously
correct.
> There's an argument to be made that since a-t-a-f is only used by clone, it
> shouldn't even bother taking a lock -- but then it should be moved to
> builtin/clone.c and reduced to a single write of the pre-deduped list, followed
> by a single read_info_alternates call. One thing at a time. Taking out the
> locking in the incremental version here doesn't really simplify the code much
> anyway.
Yeah, I agree with all of the reasoning here.
-Peff
prev parent reply other threads:[~2015-06-01 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-31 18:15 [PATCH 0/2] don't add duplicate paths to info/alternates Jim Hill
2015-05-31 18:15 ` [PATCH 1/2] add_to_alternates_file: don't add duplicate paths Jim Hill
2015-06-01 10:51 ` Jeff King
2015-05-31 18:15 ` [PATCH 2/2] remove hold_lock_file_for_append Jim Hill
2015-06-01 10:53 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150601105348.GD31792@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gjthill@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).