[PATCH 1/1]: git-completion.tcsh fails w/ noclobber

[PATCH 1/1]: git-completion.tcsh fails w/ noclobber

[Ariel Faigon]

tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users.

Helped-by: Junio C Hamano <notifications@github.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Signed-off-by: Ariel Faigon <github.2009@yendor.com>
---

 contrib/completion/git-completion.tcsh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
index 6104a42..4a790d8 100644
--- a/contrib/completion/git-completion.tcsh
+++ b/contrib/completion/git-completion.tcsh
@@ -41,7 +41,7 @@ if ( ! -e ${__git_tcsh_completion_original_script} ) then
 	exit
 endif
 
-cat << EOF > ${__git_tcsh_completion_script}
+cat << EOF >! ${__git_tcsh_completion_script}
 #!bash
 #
 # This script is GENERATED and will be overwritten automatically.

Re: [PATCH 1/1]: git-completion.tcsh fails w/ noclobber

[Christian Couder]

The subject is better but still not quite there. I suggest:

[PATCH] git-completion.tcsh: fix redirect with noclobber

On Tue, Jun 9, 2015 at 1:01 AM, Ariel Faigon <github.2009@yendor.com> wrote:
> tcsh users who happen to have 'set noclobber' elsewhere in their ~/.tcshrc or ~/.cshrc startup files get a 'File exist' error, and the tcsh completion file doesn't get generated/updated.  Adding a `!` in the redirect works correctly for both clobber (default) and 'set noclobber' users.
>
> Helped-by: Junio C Hamano <notifications@github.com>

The email address look wrong. If he really helped you, he probably
emailed you using another address.

> Mentored-by: Christian Couder <christian.couder@gmail.com>

"Mentored-by:" is used by Google Summer of Code students. If someone
helps you and you want to acknowledge that, you can add an
"Helped-by:" trailer (unless your helper tells you that you can add a
"Reviewed-by:" or maybe a "Signed-off-by:").

> Signed-off-by: Ariel Faigon <github.2009@yendor.com>
> ---